Skip to content

Commit

Permalink
bug: absence of cli flags results in argparse passing explicit None (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
sjahl authored Oct 1, 2024
1 parent 732d049 commit 3c11341
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions deploy/deployctl/subcommands/ingress_demo.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,12 @@ def apply_services(name: str, browser_deployment: str = None) -> None:
kubectl(["apply", "-f", "-"], input=manifest)


def apply_ingress(
name: str, browser_deployment: str = None, reads_service: str = "reads-bluegreen-active-prod"
) -> None:
def apply_ingress(name: str, browser_deployment: str = None, reads_service: str = None) -> None:
apply_services(name, browser_deployment)

if not reads_service:
reads_service = "reads-bluegreen-active-prod"

manifest = INGRESS_MANIFEST_TEMPLATE.format(name=name, reads_service=reads_service)

kubectl(["apply", "-f", "-"], input=manifest)
Expand All @@ -111,7 +112,6 @@ def apply_ingress(

def delete_ingress_and_services(name: str) -> None:
kubectl(["delete", f"ingress/gnomad-ingress-demo-{name}"])
kubectl(["delete", f"service/gnomad-reads-demo-{name}"])
kubectl(["delete", f"service/gnomad-browser-demo-{name}"])


Expand Down

0 comments on commit 3c11341

Please sign in to comment.