-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2 RMC dataset #1216
Add v2 RMC dataset #1216
Conversation
95f9673
to
9d14338
Compare
Hiya again @phildarnowsky-broad. Also requesting review on this one, with the hopes of getting it merged, with a submitted issue if there are design considerations that are not breaking, per standup this morning. There's at least one Thanks as always for reviewing my PRs :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagged one extremely minor change, you are good to merge soon as that's done. No need to seek re-review.
"prepare_gnomad_v2_regional_missense_constraint", | ||
prepare_gnomad_v2_regional_missense_constraint, | ||
"/constraint/gnomad_v2_regional_missense_constraint.ht", | ||
# TODO: before merging - update to a more permanent location for this data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rileyhgrant that reminds me, I actually did not do this for the SVs, I think if you have a current output Hail table in a dev environment, it'd be OK to take that and export it to the new ES rather than necessarily rerun the whole pipeline from scratch. So probably no need to worry about this now, we can move stuff around and fill in gaps in post.
</Track> | ||
</Wrapper> | ||
) | ||
// type RegionalConstraintTrackProps = OwnRegionalConstraintTrackProps & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented lines here can be deleted
9d14338
to
fc4d41a
Compare
Adds the data pipeline, graphql api, and frontend pieces required to load, serve, and render the v2 regional missense constraint (RMC) dataset.