Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 RMC dataset #1216

Merged
merged 7 commits into from
Oct 28, 2023
Merged

Add v2 RMC dataset #1216

merged 7 commits into from
Oct 28, 2023

Conversation

rileyhgrant
Copy link
Contributor

Adds the data pipeline, graphql api, and frontend pieces required to load, serve, and render the v2 regional missense constraint (RMC) dataset.

@rileyhgrant rileyhgrant self-assigned this Oct 27, 2023
@rileyhgrant rileyhgrant force-pushed the rg/v2-rmc branch 2 times, most recently from 95f9673 to 9d14338 Compare October 27, 2023 18:00
@rileyhgrant rileyhgrant marked this pull request as ready for review October 27, 2023 18:05
@rileyhgrant
Copy link
Contributor Author

Hiya again @phildarnowsky-broad.

Also requesting review on this one, with the hopes of getting it merged, with a submitted issue if there are design considerations that are not breaking, per standup this morning.

There's at least one any, and one ts-ignore comment remaining, these arise from a helper function that was created before my time (despite it being new to main here, it had lived in another branch before), I realize these are not ideal, I was having a bit of a time trying to figure out how to resolve these two remaining type errors, and am going to move onto other work for the time being.

Thanks as always for reviewing my PRs :)

Copy link
Contributor

@phildarnowsky-broad phildarnowsky-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged one extremely minor change, you are good to merge soon as that's done. No need to seek re-review.

"prepare_gnomad_v2_regional_missense_constraint",
prepare_gnomad_v2_regional_missense_constraint,
"/constraint/gnomad_v2_regional_missense_constraint.ht",
# TODO: before merging - update to a more permanent location for this data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rileyhgrant that reminds me, I actually did not do this for the SVs, I think if you have a current output Hail table in a dev environment, it'd be OK to take that and export it to the new ES rather than necessarily rerun the whole pipeline from scratch. So probably no need to worry about this now, we can move stuff around and fill in gaps in post.

</Track>
</Wrapper>
)
// type RegionalConstraintTrackProps = OwnRegionalConstraintTrackProps &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented lines here can be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants