Dont cache graphql errors #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phildarnowsky-broad
force-pushed
the
dont_cache_graphql_errors
branch
2 times, most recently
from
861ec67 to
8d4d0f4
Compare
|
FYI @sjahl |
rileyhgrant
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Nice sleuthing on this one, this will be an excellent and crucial patch to have pre-v4.
Only comment is that per Steve's slack thread (linked here again for convenience), the header should be no-store, rather than no-cache.
Other than that lookin' good.
| // Also, as written, this will no-cache not-found errors, which is | ||
| // undesirable, but something we can put off fixing until later. | ||
|
|
||
| response.set('Cache-Control', 'no-cache') |
There was a problem hiding this comment.
Per this Slack thread, I believe this should be no-store rather than no-cache, to have our desired effect
There was a problem hiding this comment.
Yes thank you nice catch
Note that one subtlety of this is that it also no-caches not-found errors, which is undesirable. If there's no, e.g., gene X now, that's going to also be the case later.
phildarnowsky-broad
force-pushed
the
dont_cache_graphql_errors
branch
from
8d4d0f4 to
9ccc331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.