-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to variant cooccurrence page #1335
Conversation
9d8814a
to
81830ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like the pattern in the testing to define a base test object then change certain properties with the spreader syntax -- very cool!
Approved with minor changes of the usual variety.
- One tiny comment on importing a constant value to reuse it
- Linter should be appeased (which I see you're currently in the process of doing)
- The DONTMERGE commit should be dropped, which I know you know, but I figure another friendly reminder (given its sufficiently friendly) almost never hurts
Nicely done as usual Phil :). I'm loving the tests.
const cisThreshold = 0.02 | ||
const transThreshold = 0.55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comment, should we import these thresholds from VariantCoocurrencePage.tsx
if they're being exported from that file anyways? One less thing to update if they ever change again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's maybe a little counterintuitive, but when I have key constants like this which drive the logic, I like to define them separately for tests. The reason is that if you change the value in the future, a bunch of your tests will break, which will reveal some implications of changing the value that you need to think about.
41b268f
to
b68f9c9
Compare
While we're at it, we also use symbolic constants rather than repeated hardcoded numeric literals for this purpose.
b68f9c9
to
91dae95
Compare
This incorporates a number of updates to the variant cooccurrence page:
There are also a good many refactorings added along the way, and some basic tests laid down.