Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-pipelines): allow pinning of hail in requirements #1554

Merged
merged 3 commits into from
May 24, 2024

Conversation

rileyhgrant
Copy link
Contributor

Allows pinning of hail in data-pipeline/requirements.txt, and pins it.

deployctl's start_cluster command now checks if the locally installed version of hail is the same as the version pinned in requirements.txt, and raises and error if not.

Since deployctl calls hailctl in its start_cluster command, this approach allows pinning of hail by manually checking the versions match.

@rileyhgrant rileyhgrant self-assigned this May 24, 2024
@rileyhgrant
Copy link
Contributor Author

Bumping pylint because of pylint-dev/pylint#3882

Copy link
Contributor

@sjahl sjahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing inline re: catching an error. Normally, I'd pause before jumping from python 3.7 -> 3.9, but 3.7 is ancient, and it looks like i've been running 3.9 in my local venv for who knows how long and deployctl has worked fine!

deploy/deployctl/subcommands/dataproc_cluster.py Outdated Show resolved Hide resolved
@rileyhgrant rileyhgrant force-pushed the allow-pinning-of-hail branch from e65d6bd to 3b49c30 Compare May 24, 2024 16:44
@rileyhgrant rileyhgrant requested a review from sjahl May 24, 2024 16:50
@rileyhgrant rileyhgrant force-pushed the allow-pinning-of-hail branch from 29adb2b to 1f50825 Compare May 24, 2024 20:10
@rileyhgrant rileyhgrant merged commit 275eb7d into main May 24, 2024
7 checks passed
@rileyhgrant rileyhgrant deleted the allow-pinning-of-hail branch May 24, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants