Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): render XX and XY sums in variant table #1581

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

rileyhgrant
Copy link
Contributor

Resolves #1579

Renders the sum XX and XY in the allele count table on variant pages. This was mistakenly dropped in a refactor.

Also adds this behavior into tests to prevent regressions.

@rileyhgrant rileyhgrant self-assigned this Jun 24, 2024
Copy link
Contributor

@phildarnowsky-broad phildarnowsky-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM

@rileyhgrant rileyhgrant merged commit 5031a3d into main Jun 26, 2024
5 checks passed
@rileyhgrant rileyhgrant deleted the fix-xy-xx-in-table branch June 26, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 Variant Table not showing total XX/XY
2 participants