-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add African local ancestry data to pop frequency table #1638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
With the assumption that edits will be made to drop the DONTMERGE
commit, and to fix the minor problems causing CI to fail.
Nicely done.
@rileyhgrant FYI I've decided it would be best to actually merge the commit currently marked |
We're about to add local ancestry group data for the African/African-American ancestry group. In preparation for this, we add some types and a basic snapshot test to characterize the behavior with existing Admixed American local ancestry data, to help guard against regressions.
Once this has been proven out in production for a while, we'll cut over the alias and change this index back to the alias.
6a3da19
to
0968b62
Compare
Demo on this passed QA, just waiting to deploy to coordinate with upcoming blog post. |
Azure is deliberately omitted for the moment until the sync process is working again. Similarly, we'll shortly be adding a blog post link to this section once that post is up.
resolves #1640 |
Resolves https://github.com/broadinstitute/gnomad-browser-team/issues/72