Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add African local ancestry data to pop frequency table #1638

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

phildarnowsky-broad
Copy link
Contributor

@phildarnowsky-broad phildarnowsky-broad commented Oct 8, 2024

Copy link
Contributor

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

With the assumption that edits will be made to drop the DONTMERGE commit, and to fix the minor problems causing CI to fail.

Nicely done.

@phildarnowsky-broad
Copy link
Contributor Author

@rileyhgrant FYI I've decided it would be best to actually merge the commit currently marked DONTMERGE, then just in case there's trouble when we deploy to prod it's easier to roll back. Once this has been up a while I'll add a separate PR to cut over the index.

We're about to add local ancestry group data for the African/African-American ancestry group. In preparation for this, we add some types and a basic snapshot test to characterize the behavior with existing Admixed American local ancestry data, to help guard against regressions.
Once this has been proven out in production for a while, we'll cut over the alias and change this index back to the alias.
@phildarnowsky-broad
Copy link
Contributor Author

Demo on this passed QA, just waiting to deploy to coordinate with upcoming blog post.

Azure is deliberately omitted for the moment until the sync process is working again. Similarly, we'll shortly be adding a blog post link to this section once that post is up.
@phildarnowsky-broad
Copy link
Contributor Author

resolves #1640

@phildarnowsky-broad phildarnowsky-broad merged commit 6625333 into main Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants