Skip to content

Conversation

@phildarnowsky-broad
Copy link
Contributor

To get tests and typechecking to pass, this also involved:

  • replacing a few calls to the now-removed withComponent API with the new as API
  • removing close to half of the remaining ts-expect-errors
  • touching up some props declarations
  • re-recording a great many snapshots

@phildarnowsky-broad phildarnowsky-broad self-assigned this Dec 12, 2025
…o latest versions

To get tests and typechecking to pass, this also involved:
  * replacing a few calls to the now-removed `withComponent` API with the new `as` API
  * removing close to half of the remaining `ts-expect-error`s
  * touching up some props declarations
  * re-recording a great many snapshots
Copy link
Contributor

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Did a glance over the changes, and poked around a local instance with these changes.

@phildarnowsky-broad phildarnowsky-broad merged commit 8cf709c into main Dec 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants