Repository navigation
Isolate render errors on major sections of pages - #1933
Open
rileyhgrant wants to merge 4 commits into
Open
rileyhgrant wants to merge 4 commits into
rileyhgrant wants to merge 4 commits into
Conversation
rileyhgrant
changed the title
rileyhgrant
force-pushed
the
rhg/page-section-error-boundaries
branch
from
August 27, 2026 23:03
9a308b9 to
349f550
Compare
Import and use a useSectionErrorBoundary hook to add render-time error handling to the major sections on pages, e.g. if the Gene Page's Variants track crashes at render time for any reason, that is caught and a warning displayed just for that track, rather than crashing the whole page with the generic 'something went wrong'
rileyhgrant
force-pushed
the
rhg/page-section-error-boundaries
branch
from
September 11, 2026 17:55
349f550 to
ab581cb
Compare
rileyhgrant
marked this pull request as ready for review
September 11, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is working towards more pleasant and workable local dev, and also represents better user experience, imo.
Add per 'section' level error boundaries, e.g. for each major track on the Gene Page (i.e. Coverage, Gene Info, Variants) so that a render time error on a single section doesn't cause the an entire page crash with the "something went wrong" error boundary page.
This is stacked on top of the ClinVar testing improvement (and bugfix).
Like that one, this PR is made up of several logical commits, each one is pretty well isolated and would make for a good review experience, imo, reviewing the entire diff is not awful, but not recommended. Github's UI has good support for viewing a single commit at a time when reviewing.
If a given section has a render error, it's caught and an error message is displayed (screenshot below). Clicking the error message opens a modal letting the user submit an issue on Github, Email, etc. Parts of the template are pre-filled, and having it be section level crashing with some automatic info filled out in a template in the form of section, dataset, etc (hopefully) gives us a bit more information about what the issue is (rather than just having a report come in that the gene page crashed somewhere).