Add region flags for joint exome genome v4.1 #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dinstitute/gnomad_qc into jg/add_region_flags_for_joint_exome_genome_v4.1 # Conflicts: # gnomad_qc/v4/create_release/create_combined_faf_release_ht.py
…to jg/add_region_flags_for_joint_exome_genome_v4.1 # Conflicts: # gnomad_qc/v4/resources/constants.py
There was a problem hiding this comment.
One thing on the data_type annotations. Also this is pure preference, but I find code easier to read/follow when all internal private methods are stacked at the top of the methods instead of imbedded in the methods code. If you like it embedded, I think its fine as is, I get its closer to the code that calls it but my brain has a little more difficulty following the flow through main function with it this way. I also recognize we havent established any style/consistency with how we do this so not a major sticking point for me.
mike-w-wilson
deleted the
jg/add_region_flags_for_joint_exome_genome_v4.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.