Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-232: create 'user' resource type #1620

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

davidangb
Copy link
Contributor

Ticket: https://broadworkbench.atlassian.net/browse/CORE-232

What:

Create a new user resource type for the sole purpose of being able to query for support permissions on the resource_type_admin/user resource.

As of this writing, we don't expect anything to create user resources themselves.

This PR is an offshoot of #1617 - see comment threads in that other PR for context.


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@davidangb davidangb marked this pull request as ready for review January 7, 2025 17:11
@davidangb davidangb requested a review from a team as a code owner January 7, 2025 17:11
Copy link
Collaborator

@dvoet dvoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care that anyone can create user resources? They don't do anything.

@davidangb davidangb mentioned this pull request Jan 8, 2025
2 tasks
Copy link

sonarqubecloud bot commented Jan 9, 2025

@davidangb davidangb merged commit 365c26e into develop Jan 9, 2025
26 checks passed
@davidangb davidangb deleted the da_CORE-232_userResourceType branch January 9, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants