parameterize table names in create_or_update_sample_tables task #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parameterizes table names used in the
create_or_update_sample_tablestask so the user can override "flowcell", "library", and "sample" with values of their choice. Sincecreate_or_update_sample_tablesreads from either a live table or json files provided as input (from demux), this should fall back gracefully to the default names if overridden but the json files have the old variable namesIt also emits tsvs with the table data, for debugging and/or so in the future the table data gathered by the
create_or_update_sample_tablestask can be uploaded using theupload_entities_tsvtask.