Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
dae78c7
add collapse_duplicated_barcodes param to illumina_demux
tomkinsc Mar 12, 2025
c63031d
revise collapse_duplicated_barcodes param description
tomkinsc Mar 12, 2025
e615ee3
revise samplesheet input param descriptions
tomkinsc Mar 12, 2025
8cf86b3
expose TILE_LIMIT and FIRST_TILE picard options in illumina_demux task
tomkinsc Mar 12, 2025
1efefa8
stub out calling illumina.py splitcode_demux as part of illumina_demu…
tomkinsc Mar 18, 2025
048cd74
illumina_demux task: expose new `rev_comp_barcodes_before_demux` and …
tomkinsc Mar 19, 2025
c5bdecb
run `illumina.py splitcode_demux` when `collapse_duplicated_barcodes=…
tomkinsc Mar 19, 2025
ae6758c
WIP
tomkinsc Mar 27, 2025
8b7eb5f
WIP
tomkinsc Mar 28, 2025
5169948
WIP
tomkinsc Mar 29, 2025
855aae4
WIP
tomkinsc Mar 29, 2025
535a3c0
cleanup
tomkinsc Mar 29, 2025
2c52253
add merging of picard-style metrics
tomkinsc Mar 29, 2025
771bd4f
add additional column to consolidated metrics to indicate the demux p…
tomkinsc Mar 29, 2025
177b572
cleanup
tomkinsc Mar 29, 2025
7552e3a
remove unused variable
tomkinsc Mar 29, 2025
d878a16
pin illumina_demux docker image for this dev branch; remove cruft; WD…
tomkinsc Mar 29, 2025
463c485
shorten flowcell_dir_path -> flowcell_dir
tomkinsc Mar 29, 2025
85b72af
WDL validation fixes
tomkinsc Mar 29, 2025
6eb1a38
rename and quote a few variables
tomkinsc Mar 31, 2025
c07abcb
fixes
tomkinsc Apr 1, 2025
35d4b83
cromwell (and womool) 87->88
tomkinsc Apr 1, 2025
4133f27
cleanup
tomkinsc Apr 1, 2025
ae5cd8e
ubuntu GitHub Actions runner ubuntu-20.04 -> ubuntu-24.04
tomkinsc Apr 1, 2025
99823ee
java version 11 -> 17; change jdk from adopt -> temurin
tomkinsc Apr 1, 2025
e512113
floor(bases_aligned) to coerce to Int
tomkinsc Apr 1, 2025
37b9abc
override check_terra_env docker image to dev build (for now)
tomkinsc Apr 9, 2025
e8ca385
set 'nullglob' shell option to avoid passing {} brace-expanded wildca…
tomkinsc Apr 17, 2025
8c17083
WIP: parameterize inner barcode demux trimming (relative to inner bar…
tomkinsc Apr 17, 2025
0980fb8
check for barcodes.txt and exit with error if absent
tomkinsc Jun 6, 2025
3143721
list pwd content after illumina demux
tomkinsc Jun 7, 2025
ac7d21f
report memory high water mark to log between illumina demux and split…
tomkinsc Jun 7, 2025
3566215
report report TMPDIR used within illumina_demux task; explicitly pass…
tomkinsc Jul 10, 2025
9a46b57
Update default docker image in illumina_demux
tomkinsc Jul 15, 2025
2d61164
guardrail on total_tile_count calculation (default to 1 for any value…
tomkinsc Jul 16, 2025
90b9835
Merge branch 'master' into ct-swiftseq-demux
tomkinsc Aug 22, 2025
1b4056e
bump viral-baseimage 0.2.4 -> 0.3.0; viral-core 2.4.1 -> 2.4.3
tomkinsc Aug 22, 2025
2f1aea5
bump viral-baseimage and viral-core docker image versions in WDL task…
tomkinsc Aug 22, 2025
8f8ee76
Merge branch 'master' into ct-swiftseq-demux
dpark01 Oct 6, 2025
6d470bb
Merge branch 'master' into ct-swiftseq-demux
dpark01 Oct 6, 2025
2153b3c
Add DEBUG logging to splitcode_demux for troubleshooting
dpark01 Nov 7, 2025
5189691
Merge branch 'master' into ct-swiftseq-demux
dpark01 Nov 8, 2025
4d9cf12
Remove vestigial flowcell_dir input from illumina_demux task
dpark01 Nov 10, 2025
671b881
clean
dpark01 Nov 11, 2025
ee094f0
Merge branch 'master' into ct-swiftseq-demux
dpark01 Nov 11, 2025
52df0c4
Merge remote-tracking branch 'origin/master' into dp-fastq-demux
dpark01 Nov 11, 2025
aa44e31
Fix MultiQC task to handle crashes from empty/invalid FastQC zip files
dpark01 Nov 11, 2025
101b3fd
Fix MultiQC task to handle crashes from empty/invalid FastQC zip files
dpark01 Nov 11, 2025
29f56d7
Merge branch 'master' into ct-swiftseq-demux
dpark01 Nov 11, 2025
17ac149
bump viral-core 2.4.3 to 2.5.0
dpark01 Nov 12, 2025
4618135
Merge branch 'dp-fastq-demux' into ct-swiftseq-demux
dpark01 Nov 12, 2025
c4f1144
allow retry
dpark01 Nov 12, 2025
25fd29c
address todo comment
dpark01 Nov 12, 2025
f8e180d
bump many docker images versions to latest
dpark01 Nov 12, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ jobs:
- name: install java
uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '11'
distribution: 'temurin'
java-version: '17'
- name: install cromwell+womtool+dxWDL
shell: bash
run: |
Expand Down Expand Up @@ -236,8 +236,8 @@ jobs:
- name: install java
uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '11'
distribution: 'temurin'
java-version: '17'
- name: install cromwell+womtool+dxWDL
shell: bash
run: |
Expand Down Expand Up @@ -365,8 +365,8 @@ jobs:
- name: install java
uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '11'
distribution: 'temurin'
java-version: '17'
- name: install miniwdl
run: |
pip3 install pyyaml dxpy
Expand Down
23 changes: 23 additions & 0 deletions github_actions_ci/check-wdl-runtimes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,29 @@
# requires $MODULE_VERSIONS to be set to point to a text file with equal-sign-separated values
# export MODULE_VERSIONS="./requirements-modules.txt" && ./github_actions_ci/check-wdl-runtimes.sh

function absolute_path() {
local SOURCE="$1"
while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symlink
DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
if [[ "$OSTYPE" == "darwin"* ]]; then
SOURCE="$(readlink "$SOURCE")"
else
SOURCE="$(readlink -f "$SOURCE")"
fi
[[ $SOURCE != /* ]] && SOURCE="$DIR/$SOURCE" # if $SOURCE was a relative symlink, we need to resolve it relative to the path where the symlink file was located
done
echo "$SOURCE"
}
SOURCE="${BASH_SOURCE[0]}"
SCRIPT=$(absolute_path "$SOURCE")
SCRIPT_DIRNAME="$(dirname "$SOURCE")"
SCRIPTPATH="$(cd -P "$(echo "$SCRIPT_DIRNAME")" &> /dev/null && pwd)"
SCRIPT="$SCRIPTPATH/$(basename "$SCRIPT")"
REPO_PATH="$(realpath "$SCRIPTPATH/../")"

# set MODULE_VERSIONS with default value of "$(realpath "$SCRIPTPATH/../requirements-modules.txt")", assumed to be located one level above this script
MODULE_VERSIONS="${MODULE_VERSIONS:-"${REPO_PATH}/requirements-modules.txt"}"

echo "Checking wdl container versions against ${MODULE_VERSIONS}"

# this is the newer script that simply validates existing version strings
Expand Down
4 changes: 2 additions & 2 deletions github_actions_ci/install-wdl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ fetch_jar_from_github () {
ln -s $_jar_fname $_tool_name.jar
}

fetch_jar_from_github broadinstitute cromwell womtool 87
fetch_jar_from_github broadinstitute cromwell cromwell 87
fetch_jar_from_github broadinstitute cromwell womtool 88
fetch_jar_from_github broadinstitute cromwell cromwell 88
fetch_jar_from_github dnanexus dxWDL dxWDL v1.50
fetch_jar_from_github dnanexus dxCompiler dxCompiler 2.11.6

Expand Down
13 changes: 11 additions & 2 deletions github_actions_ci/validate-wdl-womtool.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
#!/bin/bash
set -e -o pipefail

for workflow in pipes/WDL/workflows/*.wdl; do
echo -n "validating $workflow ... "
# if WORKFLOW_TO_VALIDATE env var is set, validate only that workflow
# ex. WORKFLOW_TO_VALIDATE=demux_deplete ./github_actions_ci/validate-wdl-womtool.sh

if [ -n "$WORKFLOW_TO_VALIDATE" ]; then
WF_GLOB_PATTERN="pipes/WDL/workflows/${WORKFLOW_TO_VALIDATE}.wdl"
else
WF_GLOB_PATTERN='pipes/WDL/workflows/*.wdl'
fi

for workflow in ${WF_GLOB_PATTERN}; do
printf "validating $workflow ... "
if $(hash -r womtool &> /dev/null); then
womtool validate $workflow
else
Expand Down
14 changes: 7 additions & 7 deletions pipes/WDL/tasks/tasks_assembly.wdl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ task assemble {
String sample_name = basename(basename(reads_unmapped_bam, ".bam"), ".taxfilt")

Int? machine_mem_gb
String docker = "quay.io/broadinstitute/viral-assemble:2.4.3.1"
String docker = "quay.io/broadinstitute/viral-assemble:2.5.1.0"
}
parameter_meta{
reads_unmapped_bam: {
Expand Down Expand Up @@ -116,7 +116,7 @@ task select_references {
Int? skani_c
Int? skani_n

String docker = "quay.io/broadinstitute/viral-assemble:2.4.3.1"
String docker = "quay.io/broadinstitute/viral-assemble:2.5.1.0"
Int machine_mem_gb = 4
Int cpu = 2
Int disk_size = 100
Expand Down Expand Up @@ -208,7 +208,7 @@ task scaffold {
Float? scaffold_min_pct_contig_aligned

Int? machine_mem_gb
String docker="quay.io/broadinstitute/viral-assemble:2.4.3.1"
String docker="quay.io/broadinstitute/viral-assemble:2.5.1.0"

# do this in multiple steps in case the input doesn't actually have "assembly1-x" in the name
String sample_name = basename(basename(contigs_fasta, ".fasta"), ".assembly1-spades")
Expand Down Expand Up @@ -585,7 +585,7 @@ task align_reads {
Boolean skip_mark_dupes = false

Int? machine_mem_gb
String docker = "quay.io/broadinstitute/viral-core:2.4.1"
String docker = "quay.io/broadinstitute/viral-core:2.5.1"

String sample_name = basename(basename(basename(reads_unmapped_bam, ".bam"), ".taxfilt"), ".clean")
}
Expand Down Expand Up @@ -722,7 +722,7 @@ task refine_assembly_with_aligned_reads {
Int min_coverage = 3

Int machine_mem_gb = 15
String docker = "quay.io/broadinstitute/viral-assemble:2.4.3.1"
String docker = "quay.io/broadinstitute/viral-assemble:2.5.1.0"
}

Int disk_size = 375
Expand Down Expand Up @@ -851,7 +851,7 @@ task run_discordance {
String out_basename = "run"
Int min_coverage = 4

String docker = "quay.io/broadinstitute/viral-core:2.4.1"
String docker = "quay.io/broadinstitute/viral-core:2.5.1"
}
parameter_meta {
reads_aligned_bam: {
Expand Down Expand Up @@ -1100,7 +1100,7 @@ task wgsim {
Int? random_seed

Int machine_mem_gb = 7
String docker = "quay.io/broadinstitute/viral-assemble:2.4.3.1"
String docker = "quay.io/broadinstitute/viral-assemble:2.5.1.0"
}

parameter_meta {
Expand Down
Loading