Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing changelog check error #1445

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Addressing changelog check error #1445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
642cd9d
reproducing error in changelog parsing
jessicaway Dec 5, 2024
f6bcd21
Merge branch 'develop' into jw_fix_changelog_bug
jessicaway Jan 9, 2025
24b817a
testing
jessicaway Jan 9, 2025
929fa52
testing
jessicaway Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ function get_versioned_pipelines() {
function get_modified_pipelines() {
local -r commitToCompare=${1}
local -r -a pipelines=($(get_versioned_pipelines))
local -r -a changedWdls=($(git diff --name-only HEAD ${commitToCompare} | grep -E '.*\.wdl' | xargs -n1 basename))
#local -r -a changedWdls=($(git diff --name-only HEAD ${commitToCompare} | grep -E '.*\.wdl' | xargs -n1 basename))
local -r -a changedWdls=($(git diff --name-only HEAD ${commitToCompare} | grep -E '.*\.wdl' | xargs -n1 basename || echo ""))
local -a modifiedPipelines=()
for pipeline in ${pipelines[@]}; do
if [[ " ${changedWdls[@]}" =~ " $(basename ${pipeline})" ]]; then
Expand Down
2 changes: 2 additions & 0 deletions scripts/validate_release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ function validate_changelog_changes() {

function validate_versions_and_changelogs() {
local commitToCompare=${1}
echo "Finding modified pipelines"
local -r -a modifiedPipelines=($(get_modified_pipelines ${commitToCompare}))
echo "Found modified pipelines"
local allPipelinesValid=true

stderr "Comparing versions and changelogs for pipelines that differ from the versions on '${commitToCompare}':"
Expand Down
Loading