one-to-many file support #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanpenner @joliss ping |
| @@ -73,7 +85,7 @@ describe('Filter', function() { | |||
| function write(relativePath, contents, encoding) { | |||
| encoding = encoding === void 0 ? 'utf8' : encoding; | |||
| mkdirp.sync(path.dirname(relativePath)); | |||
| fs.writeFileSync(relativePath, contents, { | |||
| fs.writKeepOriginalFiltereFileSync(relativePath, contents, { | |||
There was a problem hiding this comment.
Not sure what is going on here.
|
@chriseppstein I like this approach as opposed to a hook. Adding a hook a dev implements is more in the vein of Broccoli APIs, however I think you would loose the flexibility that this approach affords. |
add test to cover rebuild for multiple file output
update to use broccoli-kitchen-sink-helpers 0.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently published as a fork, but if the direction here is something folks like, I will be happy to re-work this PR into something mergable. For now, I'd like to get feedback. Specifically, I find that the
targetExtensionproperty, probably doesn't make as much sense now but I'm not sure how to maintain backwards compat otherwise.From the original README:
Q: Can this help with compilers that are almost 1:1, like a minifier that takes
-a
.jsand.js.mapfile and outputs a.jsand.js.mapfile?A: I don't know yet how to implement this and still have the API look beautiful. We also have to make sure that caching works correctly, as we have to invalidate if either the
.jsor the.js.mapfile changes.I'm not sure if this API is considered "beautiful" (such is in the eye of the beholder) but it is identical to the original API until you need to add a second output file at which point you just need to accept a new argument and call a callback with the string and the relative filename. This works with caching.