Skip to content

Conversation

@fpseverino
Copy link

No description provided.

@fpseverino
Copy link
Author

fpseverino commented May 13, 2025

Should all public structs be marked Sendable? I marked only those that gave warnings in tests

EDIT: In the next commit I made everything Sendable.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpseverino thank you! Yeah if you could make all the public types Sendable, that should stop any issues that are missed by missing tests

@fpseverino
Copy link
Author

fpseverino commented May 13, 2025

Yeah if you could make all the public types Sendable, that should stop any issues that are missed by missing tests

I should have done it for all remaining types in this commit: e35f5cc

EDIT: missed one 😅 bb61ff4

@fpseverino fpseverino requested a review from 0xTim May 13, 2025 19:54
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit 14a5a68 into brokenhandsio:main May 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants