Skip to content

Conversation

@samalone
Copy link
Contributor

The purpose of adding aaguid accessors is to allow a server to map the ID to a provider name using tables like those on https://github.com/passkeydeveloper/passkey-authenticator-aaguids.

…ong with tests to verify correct behavior and default values.
Copilot AI review requested due to automatic review settings November 24, 2025 14:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds convenient accessor properties for the Authenticator Attestation Globally Unique Identifier (AAGUID) to the Credential and AttestationObject structs. The AAGUID is a 128-bit identifier that allows servers to identify authenticator make and model, enabling them to map these identifiers to provider names using public registries.

Key Changes:

  • Added public aaguid computed property to Credential that delegates to the underlying attestation object
  • Added public aaguid computed property to AttestationObject that extracts the AAGUID from authenticator data
  • Added comprehensive test coverage for both custom AAGUIDs and the default anonymous AAGUID behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Sources/WebAuthn/Ceremonies/Registration/Credential.swift Added public aaguid computed property that delegates to attestationObject.aaguid for convenient access
Sources/WebAuthn/Ceremonies/Registration/AttestationObject.swift Added public aaguid computed property that extracts AAGUID from authenticatorData.attestedData
Tests/WebAuthnTests/WebAuthnManagerRegistrationTests.swift Added two parameterized tests covering custom AAGUID values and default anonymous AAGUID behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@dimitribouniol dimitribouniol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@dimitribouniol dimitribouniol merged commit 0a675b9 into brokenhandsio:main Nov 24, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants