Add 'include' and 'exclude' options for more fine-tuned control over brfs'd files #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both options take a minimatch pattern in a string, which is matched against absolute path of the file being transformed. Example: browserify -g [ brfs --exclude '**/node_modules/problematic/*' ] ...
This helps contributors to keep the source format consistent, e.g. preserving the whitespace indentation in empty lines.
|
What about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project where I need to exclude certain source files from being transformed by brfs (due to various reasons). I found many issues where people have similar needs, e.g. #76 #70 #55 #41.
This pull request adds support for opts.include and opts.exclude, both taking a minimatch pattern, which is matched against the source file path being transformed. Minimatch was already a dependency by browserify#glob.
Usage examples:
browserify -g [ brfs --exclude '**/node_modules/problematic/*' ] ...browserify -g [ brfs --include '**/src/foo/bar/**' ] ...I also added .editorconfig, which helps other contributors to maintain the formatting style of the project (e.g. disable whitespace trimming).