Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtle undefined fix #227

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Subtle undefined fix #227

wants to merge 4 commits into from

Conversation

mat50015
Copy link

Added a polyfill for webcrypto, which fixes subtle undefined error.

This pull request contains pull request 215 for fixing the other missing parts.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused; this PR is adding two functions (#215), plus "webcrypto". Why do we need that?

Either way, please remove PR 215, so this PR only contains your additions.

@ljharb ljharb marked this pull request as draft November 25, 2023 05:56
index.js Outdated
Comment on lines 93 to 95
var { Crypto } = require('@peculiar/webcrypto')
var crypto = new Crypto()
exports.webcrypto = crypto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peculiar/webcrypto seems not browser compatible as it says in their README:

Module is based on NodeJS v10 Crypto API. It would work only with Node v10 and higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants