Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to have problems with npm linked dependencies #66

Open
abritinthebay opened this issue May 6, 2015 · 3 comments
Open

Seems to have problems with npm linked dependencies #66

abritinthebay opened this issue May 6, 2015 · 3 comments

Comments

@abritinthebay
Copy link

If I have in my my code say require("immutable") and in an npm linked module elsewhere on my system the same require code it gets treated as two different libraries when factored and doesn't end up in the common bundle.

It's odd, and it works fine when not using npm link. I can only assume it's something to do with the paths of those files being quite different (ie, when linked it's not in the normal dep tree of the core code).

Frustrating though, especially when dealing with applications that are developed locally with private modules as abstracted parts of the core app. It very much bloats the code.

@terinjokes
Copy link
Contributor

You're probably right, I'll take a look.

@abritinthebay
Copy link
Author

Thanks! Obviously I can work around it (unlinking before building bundles) but... less than ideal :)

@abritinthebay
Copy link
Author

Update - this also causes lots of "fun" when using React - as it completely breaks React's refs for some reason.

This actually might be a browserify issue rather than a factor-bundle issue (just that it ends up screwing up factor-bundle too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants