Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure output directory exists before creating write stream #84

Closed
wants to merge 1 commit into from

Conversation

nwoltman
Copy link

@nwoltman nwoltman commented Feb 6, 2016

Fixes #83

@nwoltman
Copy link
Author

@substack @terinjokes

@terinjokes
Copy link
Contributor

I can understand this functionality being part of the CLI tool, but it doesn't belong as part of the library.

See also #70 (comment)

@nwoltman
Copy link
Author

That sounds reasonable. Would you accept a PR if I added output directory creation to the CLI tool? Would you accept this PR if I moved the output directory creation to the CLI tool?

@nwoltman
Copy link
Author

Actually, adding it to the CLI isn't helpful. I'm using factor-bundle with grunt-browserify (like so) which directly uses factor-bundle/index.js, so that's where this needs to live.

@terinjokes
Copy link
Contributor

@woollybogger then I think your best course of action is to create the output directory before using grunt-browserify.

@nwoltman
Copy link
Author

@terinjokes Yeah that's what I'm currently doing. It's just pretty annoying because it adds 7 extra lines to my Gruntfile 😞 (which is also sort of funny because it only takes adding 2 lines in this repo to fix this for everyone). Oh well.

@nwoltman nwoltman closed this Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants