Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix for big-endian platforms (Closes: #85) #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add fix for big-endian platforms (Closes: #85) #105

wants to merge 1 commit into from

Conversation

guimard
Copy link

@guimard guimard commented Jan 19, 2022

This fixes #85

utkarsh2102
utkarsh2102 suggested changes Jan 20, 2022
View reviewed changes
Copy link

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @guimard, for this patch! \o/

However, this still doesn't resolve the s390x failure completely; see the following logs:
https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/s390x/n/node-pbkdf2/20220120_013605_914b3@/log.gz

Let me know what you think?

@guimard
Copy link
Author

guimard commented Jan 27, 2022

Thank you, @guimard, for this patch! \o/

However, this still doesn't resolve the s390x failure completely; see the following logs: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/s390x/n/node-pbkdf2/20220120_013605_914b3@/log.gz

Let me know what you think?

Fixed now

@utkarsh2102
Copy link

All tests pass on all architectures now. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarsh2102 utkarsh2102 utkarsh2102 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guimard @utkarsh2102