Update to recent js-reporters and mocha #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to mocha 3.4.2 * Update to js-reporters 1.2.0 * Fix few issues in `server.js` caused by the update - `js-reporters` use NodeJS `process` which fails in a browser. Add fake init ahead of script to avoid errors. - `js-reporters` dist has `var index$10` which is treated as regex ref. Use split/join approach instead of regex replace.
Closed
Krinkle
added a commit
to qunitjs/js-reporters
that referenced
this pull request
Sep 24, 2020
Follows-up 3708273. Now that I've had a while to take inventory, I think we can bring this back to make distribution and re-use a bit easier for things like browserstack-runner. Highlights: * Switch from 'chalk' to 'kleur'. Kleur is a a dependency-free alternative that is safe to run in a browser environment without needing to do anything extra to emulate Node etc. Downstream browserstack-runner was having to mock the Node 'process' global previously because of this. There are ways around that, but it's naturally simplest to just not have any code that is just naturally agnostic of Node vs browser. Ref browserstack/browserstack-runner#179. * Use Karma to run the unit tests in the browser. * Use NYC to generate a code coverage report over the unit and integration tests.
Krinkle
added a commit
to qunitjs/js-reporters
that referenced
this pull request
Sep 24, 2020
Follows-up 3708273. Now that I've had a while to take inventory, I think we can bring this back to make distribution and re-use a bit easier for things like browserstack-runner. Highlights: * Switch from 'chalk' to 'kleur'. Kleur is a a dependency-free alternative that is safe to run in a browser environment without needing to do anything extra to emulate Node etc. Downstream browserstack-runner was having to mock the Node 'process' global previously because of this. There are ways around that, but it's naturally simplest to just not have any code that is just naturally agnostic of Node vs browser. Ref browserstack/browserstack-runner#179. * Use Karma to run the unit tests in the browser. * Use NYC to generate a code coverage report over the unit and integration tests.
Krinkle
added a commit
to qunitjs/js-reporters
that referenced
this pull request
Sep 24, 2020
Follows-up 3708273. Now that I've had a while to take inventory, I think we can bring this back to make distribution and re-use a bit easier for things like browserstack-runner. Highlights: * Switch from 'chalk' to 'kleur'. Kleur is a a dependency-free alternative that is safe to run in a browser environment without needing to do anything extra to emulate Node etc. Downstream browserstack-runner was having to mock the Node 'process' global previously because of this. There are ways around that, but it's naturally simplest to just not have any code that is just naturally agnostic of Node vs browser. Ref browserstack/browserstack-runner#179. * Use Karma to run the unit tests in the browser. * Use NYC to generate a code coverage report over the unit and integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server.jscaused by the updatejs-reportersuse NodeJSprocesswhich fails in a browser.Add fake init ahead of script to avoid errors.
js-reportersdist hasvar index$10which is treated as regex ref.Use split/join approach instead of regex replace.