Skip to content

fix(EWM-586): always update biometry pwd #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −15
Open

fix(EWM-586): always update biometry pwd #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions lib/app/service/biometry_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,19 +181,6 @@ class BiometryService {
}
}

/// This method typically called after password of seed was changed.
/// If biometry enabled - update password of [publicKey] in storage
/// even if there was no password before, because if biometry enabled, we must
/// store all passwords.
Future<void> updatePasswordIfPossible({
required PublicKey publicKey,
required String newPassword,
}) async {
if (isEnabled) {
return setKeyPassword(publicKey: publicKey, password: newPassword);
}
}

/// Try to authenticate user with biometry or throw exception.
/// Attempts count are managed by system.
Future<bool> _authenticate(String localizedReason) async {
Expand Down
5 changes: 3 additions & 2 deletions ...rofile/manage_seeds_accounts/widgets/change_seed_password/change_seed_password_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,11 @@ class ChangeSeedPasswordModel extends ElementaryModel {
newPassword: newPassword,
);

await _biometryService.updatePasswordIfPossible(
await _biometryService.setKeyPassword(
publicKey: publicKey,
newPassword: newPassword,
password: newPassword,
);
await _passwordService.reset(publicKey);
}

Future<bool> checkKeyPassword({
Expand Down