Archives node #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashinov
force-pushed
the
feat/archives-node
branch
4 times, most recently
from
b98ba74 to
2fce026
Compare
pashinov
force-pushed
the
feat/archives-node
branch
4 times, most recently
from
5682a40 to
eef145c
Compare
0xdeafbeef
reviewed
Jan 20, 2025
archives-node/src/subscriber.rs
Outdated
| }; | ||
|
|
||
| let mut writer = WriteMultipart::new(upload); | ||
| for (_, chunk) in storage.block_storage().archive_chunks_iterator(archive_id) { |
There was a problem hiding this comment.
you've added this method to context
There was a problem hiding this comment.
we can't clone context ref to spawn task. just clone Arc
pashinov
force-pushed
the
feat/archives-node
branch
3 times, most recently
from
461065f to
f34c034
Compare
pashinov
force-pushed
the
feat/archives-node
branch
2 times, most recently
from
387440b to
773db95
Compare
|
Please check if archive was already uploaded |
pashinov
force-pushed
the
feat/archives-node
branch
5 times, most recently
from
1460d83 to
22ddcf2
Compare
pashinov
force-pushed
the
feat/archives-node
branch
from
22ddcf2 to
8f32646
Compare
pashinov
force-pushed
the
feat/archives-node
branch
2 times, most recently
from
dda7dd4 to
87fc8ad
Compare
pashinov
force-pushed
the
feat/archives-node
branch
from
87fc8ad to
664e2e2
Compare
pashinov
force-pushed
the
feat/archives-node
branch
from
d53eb7f to
ff6f5aa
Compare
0xdeafbeef
reviewed
Feb 7, 2025
archives-downloader/src/main.rs
Outdated
| if config.metrics.is_some() { | ||
| spawn_allocator_metrics_loop(); | ||
| } | ||
| spawn_allocator_metrics_loop(); |
0xdeafbeef
reviewed
Feb 7, 2025
archives-downloader/src/main.rs
Outdated
Comment on lines
88
to
141
| pub fn spawn_allocator_metrics_loop() { | ||
| tokio::spawn(async move { | ||
| loop { | ||
| let s = match fetch_stats() { | ||
| Ok(s) => s, | ||
| Err(e) => { | ||
| tracing::error!("failed to fetch jemalloc stats: {e}"); | ||
| return; | ||
| } | ||
| }; | ||
|
|
||
| set_metrics!( | ||
| "jemalloc_allocated_bytes" => s.allocated, | ||
| "jemalloc_active_bytes" => s.active, | ||
| "jemalloc_metadata_bytes" => s.metadata, | ||
| "jemalloc_resident_bytes" => s.resident, | ||
| "jemalloc_mapped_bytes" => s.mapped, | ||
| "jemalloc_retained_bytes" => s.retained, | ||
| "jemalloc_dirty_bytes" => s.dirty, | ||
| "jemalloc_fragmentation_bytes" => s.fragmentation, | ||
| ); | ||
| tokio::time::sleep(std::time::Duration::from_secs(5)).await; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| pub struct JemallocStats { | ||
| pub allocated: u64, | ||
| pub active: u64, | ||
| pub metadata: u64, | ||
| pub resident: u64, | ||
| pub mapped: u64, | ||
| pub retained: u64, | ||
| pub dirty: u64, | ||
| pub fragmentation: u64, | ||
| } | ||
|
|
||
| fn fetch_stats() -> anyhow::Result<JemallocStats, tikv_jemalloc_ctl::Error> { | ||
| // Stats are cached. Need to advance epoch to refresh. | ||
| epoch::advance()?; | ||
|
|
||
| Ok(JemallocStats { | ||
| allocated: stats::allocated::read()? as u64, | ||
| active: stats::active::read()? as u64, | ||
| metadata: stats::metadata::read()? as u64, | ||
| resident: stats::resident::read()? as u64, | ||
| mapped: stats::mapped::read()? as u64, | ||
| retained: stats::retained::read()? as u64, | ||
| dirty: (stats::resident::read()? | ||
| .saturating_sub(stats::active::read()?) | ||
| .saturating_sub(stats::metadata::read()?)) as u64, | ||
| fragmentation: (stats::active::read()?.saturating_sub(stats::allocated::read()?)) as u64, | ||
| }) | ||
| } |
There was a problem hiding this comment.
can you move it into some utill? maybe in tycho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.