Skip to content

Commit

Permalink
chore: remove typeguard checks
Browse files Browse the repository at this point in the history
Found a bug with typeguard that's theoritically already solved
(agronholm/typeguardi#373). Maybe this is a edge-case. Not sure.

Given the current maintainer don't have time to dedicate to
the project (agronholm/typeguard#198), let's just remove these
checks. We can later add [pytest-beartype][pytest-beartype] as an alternative.

[pytest-beartype]: https://github.com/beartype/pytest-beartype
  • Loading branch information
bruno-fs committed Aug 13, 2024
1 parent 68fe5b3 commit 2dfa4df
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 37 deletions.
1 change: 0 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
- { python: "3.8", os: "ubuntu-latest", session: "tests" }
- { python: "3.12", os: "windows-latest", session: "tests" }
- { python: "3.12", os: "macos-latest", session: "tests" }
- { python: "3.12", os: "ubuntu-latest", session: "typeguard" }
- { python: "3.12", os: "ubuntu-latest", session: "xdoctest" }
- { python: "3.12", os: "ubuntu-latest", session: "docs-build" }

Expand Down
9 changes: 0 additions & 9 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"pre-commit",
"safety",
"tests",
"typeguard",
"xdoctest",
"docs-build",
)
Expand Down Expand Up @@ -162,14 +161,6 @@ def coverage(session: Session) -> None:
session.run("coverage", *args)


@session(python=python_versions[0])
def typeguard(session: Session) -> None:
"""Runtime type checking using Typeguard."""
session.install(".")
session.install("typeguard", *test_requirements)
session.run("pytest", f"--typeguard-packages={package}", *session.posargs)


@session(python=python_versions)
def xdoctest(session: Session) -> None:
"""Run examples with xdoctest."""
Expand Down
33 changes: 7 additions & 26 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ safety = ">=1.10.3"
sphinx = ">=4.3.2"
sphinx-autobuild = ">=2021.3.14"
sphinx-click = ">=3.0.2"
typeguard = ">=2.13.3"
xdoctest = { extras = ["colors"], version = ">=0.15.10" }

[tool.poetry.scripts]
Expand Down

0 comments on commit 2dfa4df

Please sign in to comment.