Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding handler for definitions and internal $refs. #23

Merged
merged 10 commits into from
May 3, 2016

Conversation

ocschwar
Copy link

This simple change populates the schemaMap with a copy of a definition where ever one is referred to with a $ref.

@idelvall
Copy link
Member

Hi Omri,
could you add an example to index.html showing the new functionality?
Thanks!

pattern and a button for non-pattern-defeined peroperties.
@ocschwar
Copy link
Author

Done.

Also, my fork now has a handler for patternProperties too, as well as greying out for elements marked readOnly. (basic types are greyed out, and array types marked as "readOnly" have the addButton and removeButtons greyed out. Not sure how or whether to do the same with objects and one's.

@idelvall
Copy link
Member

Hi Omri, excuse the delay, I have been very busy lately... First of all thank you for your contributions!
I am working on it now

@idelvall idelvall merged commit 37bdfc3 into brutusin:master May 3, 2016
@idelvall
Copy link
Member

idelvall commented May 3, 2016

Hi Omri, I've just merged your PR.
I did some minor refactoring so you should merge your code to align ourselves.

The readonly implementation (http://brutusin.org/json-forms/#12) seems to be unfinished. Shouldn't the input values be also disabled? I think so.

I open a new issue for it
#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants