Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioner for Python 3 #275

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Partitioner for Python 3 #275

wants to merge 22 commits into from

Conversation

adrianespejo
Copy link
Collaborator

This is the implementation of the dynamic task granularity scheduler. All previous functionality still works.

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9861982). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #275   +/-   ##
=========================================
  Coverage          ?   92.74%           
=========================================
  Files             ?       32           
  Lines             ?     5282           
  Branches          ?        0           
=========================================
  Hits              ?     4899           
  Misses            ?      383           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9861982...9366875. Read the comment docs.

Copy link
Collaborator

@polsm91 polsm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many divisions, make sure that you never divide by 0 :)

In the future, if we need to add more partition strategies consider using Enum. I think it's okay for now to have the strategy as a string.

https://docs.python.org/3/library/enum.html



def partitioner_split(father):
if hasattr(config, "partition_strategy"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion :)

strategy = getattr(config, "partition_strategy". "SIMPLE")
return Partitioner(father, strategy).split()

hecuba_py/hecuba/partitioner.py Show resolved Hide resolved
hecuba_py/hecuba/partitioner.py Show resolved Hide resolved
hecuba_py/hecuba/partitioner.py Outdated Show resolved Hide resolved
hecuba_py/hecuba/partitioner.py Show resolved Hide resolved
Copy link
Collaborator

@polsm91 polsm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working. The tokens partitions eats the memory and does a loooong loop because of "token_range_size"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants