-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partitioner for Python 3 #275
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=========================================
Coverage ? 92.74%
=========================================
Files ? 32
Lines ? 5282
Branches ? 0
=========================================
Hits ? 4899
Misses ? 383
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many divisions, make sure that you never divide by 0 :)
In the future, if we need to add more partition strategies consider using Enum. I think it's okay for now to have the strategy as a string.
hecuba_py/hecuba/partitioner.py
Outdated
|
||
|
||
def partitioner_split(father): | ||
if hasattr(config, "partition_strategy"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion :)
strategy = getattr(config, "partition_strategy". "SIMPLE")
return Partitioner(father, strategy).split()
b244134
to
006968b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not working. The tokens partitions eats the memory and does a loooong loop because of "token_range_size"
892085e
to
9861982
Compare
This is the implementation of the dynamic task granularity scheduler. All previous functionality still works.