Skip to content

Commit

Permalink
Merge pull request #72 from bskinn/71-add-ci-typecheck
Browse files Browse the repository at this point in the history
Add type-check CI for PRs.

Merging to get the workflow active on PRs, then re-opening.
  • Loading branch information
bskinn authored Mar 29, 2024
2 parents 6f1b7af + 39e8ceb commit 15b433c
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 2 deletions.
27 changes: 27 additions & 0 deletions .github/check_types.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: check-types

on:
pull_request:
branches:
- main

jobs:
format:
name: Typecheck Codebase
runs-on: ubuntu-latest

steps:
- name: Check out repo
uses: actions/checkout@v4

- name: Set up Node w/caching
uses: actions/setup-node@v4
with:
cache: 'npm'
cache-dependency-path: 'package-lock.json'

- name: Install deps
run: npm install

- name: Run formatting check
run: npm run type-check
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"format": "run-s format:code format:mermaid format:tocs",
"tsc": "npx tsc --noEmit",
"type-check": "npx tsc --noEmit",
"build": "run-s dev:clean dev:build dev:assets dev:manifest",
"build-prod": "run-s prod:clean prod:build prod:assets prod:manifest",
"clean": "npm run dev:clean",
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/state.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { TRoundTurnInfo } from '@/types/types-score-scrape'

import { BONUS_TURN_ID } from '@/consts'

export const calcRoundTurn = (raw_turn: TRawTurnId): TRoundTurnInfo => {
export const calcRoundTurn = (raw_turn: TRawTurnIdxx): TRoundTurnInfo => {
// raw_turn is zero-indexed
// The output round and in-round turn are one-indexed
if (raw_turn <= 7) {
Expand Down

0 comments on commit 15b433c

Please sign in to comment.