Adds email settings page

dpxdt/server/auth.py

@@ -577,7 +577,7 @@ def save_admin_log(build, **kwargs):
 
 @app.route('/activity')
 @fresh_login_required
-@build_access_required('id')
+@build_access_required('build_id')
 def view_admin_log():
     """Page for viewing the log of admin activity."""
     build = g.build

dpxdt/server/forms.py

@@ -19,8 +19,8 @@
 
 # Local libraries
 from flask.ext.wtf import (
-    BooleanField, DataRequired, Form, HiddenField, IntegerField,
-    Length, NumberRange, Required, SubmitField, TextField)
+    BooleanField, DataRequired, Email, Form, HiddenField, IntegerField,
+    Length, NumberRange, Optional, Required, SubmitField, TextField)
 
 # Local modules
 from . import app
@@ -96,3 +96,13 @@ class ModifyWorkQueueTaskForm(Form):
     action = HiddenField()
     delete = SubmitField('Delete')
     retry = SubmitField('Retry')
+
+
+class SettingsForm(Form):
+    """Form for modifying build settings."""
+
+    send_email = BooleanField('Send notification emails')
+    email_alias = TextField('Mailing list for notifications',
+                            validators=[Optional(), Email()])
+    build_id = HiddenField(validators=[NumberRange(min=1)])
+    save = SubmitField('Save')

dpxdt/server/frontend.py

@@ -340,6 +340,35 @@ def view_run():
     return response
 
 
-@app.route('/static/dummy')
-def view_dummy_url():
-    return app.send_static_file('dummy/index.html')
+@app.route('/settings', methods=['GET', 'POST'])
+@auth.build_access_required('build_id')
+def build_settings():
+    build = g.build
+
+    settings_form = forms.SettingsForm()
+
+    if settings_form.validate_on_submit():
+        build.send_email = settings_form.send_email.data
+        build.email_alias = settings_form.email_alias.data
+
+        logging.info('Setting build_id=%r, send_email=%r, email_alias=%r',
+                     build.id, build.send_email, build.email_alias)
+
+        db.session.add(build)
+        db.session.commit()
+
+        signals.build_updated.send(app, build=build, user=current_user)
+
+        return redirect(url_for(
+            request.endpoint,
+            build_id=build.id))
+
+    # Update form values for rendering
+    settings_form.build_id.data = build.id
+    settings_form.email_alias.data = build.email_alias
+    settings_form.send_email.data = build.send_email
+
+    return render_template(
+        'view_settings.html',
+        build=build,
+        settings_form=settings_form)

dpxdt/server/operations.py

@@ -320,12 +320,17 @@ def evict(self):
 
 
 
-# Connect API events to cache eviction.
+# Connect Frontend and API events to cache eviction.
+
+
+def _evict_user_cache(sender, user=None, build=None):
+    UserOps(user.get_id()).evict()
 
 
 def _evict_build_cache(sender, build=None, release=None, run=None):
     BuildOps(build.id).evict()
 
 
+signals.build_updated.connect(_evict_user_cache, app)
 signals.release_updated_via_api.connect(_evict_build_cache, app)
 signals.run_updated_via_api.connect(_evict_build_cache, app)

dpxdt/server/signals.py

@@ -23,6 +23,12 @@
 _signals = Namespace()
 
 
+# The build settings have been modified. Sender is the app. Arguments
+# are (models.Build, models.User). Signal is sent immediately *after* the
+# Build is committed to the DB.
+build_updated = _signals.signal('build-updated')
+
+
 # A release has been created or updated via the API. Sender is the app.
 # Arguments are (models.Build, models.Release). Signal is sent immediately
 # *after* the Release is committed to the DB.

dpxdt/server/templates/view_admins.html

@@ -30,7 +30,10 @@ <h4>Add admin</h4>
         <form action="{{ url_for('manage_admins') }}" method="post">
             {{ add_form.csrf_token }}
             {{ add_form.build_id }}
-            {{ add_form.email_address.label }} {{ add_form.email_address }}
+            <div>
+                {{ add_form.email_address.label }}
+                {{ add_form.email_address }}
+            </div>
             <br>
             {{ add_form.add(class_='btn btn-primary') }}
         </form>

dpxdt/server/templates/view_api_keys.html

@@ -30,7 +30,10 @@ <h4>Create a new API key</h4>
         <form action="{{ url_for('manage_api_keys') }}" method="post">
             {{ create_form.csrf_token }}
             {{ create_form.build_id }}
-            {{ create_form.purpose.label }} {{ create_form.purpose }}
+            <div>
+                {{ create_form.purpose.label }}
+                {{ create_form.purpose }}
+            </div>
             <br>
             {{ create_form.create(class_='btn btn-primary') }}
         </form>

dpxdt/server/templates/view_build.html

@@ -129,10 +129,12 @@ <h4>Releases</h4>
 
 {% block footer_left %}
 
-<a href="{{ url_for('manage_admins', build_id=build.id) }}">Manage admins</a>
+<a href="{{ url_for('build_settings', build_id=build.id) }}">Settings</a>
 &ndash;
-<a href="{{ url_for('manage_api_keys', build_id=build.id) }}">Set up API keys</a>
+<a href="{{ url_for('manage_admins', build_id=build.id) }}">Admins</a>
 &ndash;
-<a href="{{ url_for('view_admin_log', id=build.id) }}">Activity log</a>
+<a href="{{ url_for('manage_api_keys', build_id=build.id) }}">API keys</a>
+&ndash;
+<a href="{{ url_for('view_admin_log', build_id=build.id) }}">Activity</a>
 
 {% endblock footer_left %}

dpxdt/server/templates/view_settings.html

@@ -0,0 +1,50 @@
+{% extends 'base.html' %}
+
+{% block title -%}
+{{ build.name }} › Settings
+{%- endblock title %}
+
+{% block description -%}
+Settings for '{{ build.name }}'
+{%- endblock description %}
+
+{% block body %}
+
+<div class="row">
+    <div class="span12">
+        <h4>Settings</h4>
+
+        {% if settings_form.errors %}
+            <div class="row">
+                <div class="span6 alert alert-error">
+                {% for field, field_errors in settings_form.errors|dictsort %}
+                    <div>
+                        Invalid {{ settings_form[field].label(class="inline") }}
+                    </div>
+                {% endfor %}
+                </div>
+            </div>
+        {% endif %}
+
+        <form autocomplete="off" action="{{ url_for('build_settings') }}" method="post">
+            {{ settings_form.csrf_token }}
+            {{ settings_form.build_id }}
+            <div>
+                <label class="checkbox" for="{{ settings_form.send_email.label.field_id }}">
+                    {{ settings_form.send_email }}
+                    {{ settings_form.send_email.label.text }}
+                </label>
+                <span class="help-block">e.g., When a release is ready for review</span>
+            </div>
+            <div>
+                {{ settings_form.email_alias.label }}
+                {{ settings_form.email_alias }}
+                <span class="help-block">Otherwise sent to build admins</span>
+            </div>
+            <br>
+            {{ settings_form.save(class_='btn btn-primary') }}
+        </form>
+    </div>
+</div>
+
+{% endblock body %}