Making all JSON Config properties case insensitive #107
Conversation
|
@bslatkin any free time for a code review? :) |
| @@ -36,6 +36,7 @@ | |||
| from dpxdt.client import process_worker | |||
| from dpxdt.client import timer_worker | |||
| from dpxdt.client import workers | |||
| import preprocess_argv | |||
There was a problem hiding this comment.
Can you make this a global import instead of a relative one?
from dpxdt.tools import preprocess_argv
There was a problem hiding this comment.
For sure, that has been changed.
|
I'm sorry for the delay in reviewing this!!! Will leave comments this week. Thanks for the pull request! |
odeke-em
force-pushed
the
master
branch
2 times, most recently
from
7b54aef
to
f0065d3
Compare
|
No worries, I totally understand how busy things can get. |
odeke-em
force-pushed
the
master
branch
2 times, most recently
from
9f38382
to
438e59f
Compare
| @@ -3,17 +3,17 @@ | |||
| source common.sh | |||
|
|
|||
| ./dpxdt/runserver.py \ | |||
There was a problem hiding this comment.
Modified the config to illustrate the changes in effect.
|
@bslatkin ping! |
|
Hey Emmanuel! I'm really sorry for the delay here. I looked through this again. I think there was some misunderstanding about what the intention of #72 was. It wasn't to make the FLAGS values case insensitive. I'd like to keep those as they are, so this patch isn't going to work :( Instead, what we wanted to do was make the https://github.com/bslatkin/dpxdt#format-of-config Sorry for putting off this review for so long. I felt bad about telling you that this wasn't the intention of the original issue. If you're not interested in making the changes no worries. Thanks for your patience. -Brett |
|
Hello Brett, Cheers, |
|
Thanks for being so understanding and the kind words. I really appreciate it! |
This addresses issue #72