Additional Logging #111
Merged
Additional Logging #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This mitigates #104 by making it clearer where the logs are. |
|
I'm going to merge. Feel free to leave comments & I'll address them in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logs stack traces when there are JS errors in the capture log. Previously it would log "[Object object]" for every function in the stack.
This also prints out the path to every log file generated by local dpxdt. Previously these were only visible if you ran with
--verbose, at which point they were buried in stack traces and other messages. They're essential for debugging, and this puts them front and center.Fixes #110