update origin master #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we now share `env` by passing it around, not by relying on the module cache.
It turns out that JSDoc's dependency-injection needs are pretty simple; we mostly just need to pass around some data, plus some logging functions. That means the previous solution was overengineered, even though it was still pretty lightweight. Now we just put everything in the `Env` object and pass that around instead.
I did some quick-and-dirty profiling, and these functions made up ~2% of the flamegraph, mostly for when they called through to the type parser; also, it's likely that they'll be called repeatedly with many of the same inputs. Memoizing the functions cuts them to ~1% of the flamegraph.
- [email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected] - @jsdoc/[email protected]
…e doclet meta info
Starting point for a public API for JSDoc.
Previously, we used `exports.NAME`, which was both incorrect and confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream->master
update-origin-master-from-origin-upstream
origin->master