Skip to content

Optimization with windowed shamir, correction of bugs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdubois-crypto wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Optimization with windowed shamir, correction of bugs #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2e70308
implement windowed shamir
Feb 22, 2023
ff2fb9a
Implementing windowed shamir's trick
Feb 24, 2023
9066c66
XYZZ coordinates
Feb 28, 2023
629a94b
shamir 8 dimensions
Mar 1, 2023
45e2999
cut precomputations in 2 parts
Mar 1, 2023
301dc7c
precomputations
Mar 1, 2023
ade0a6a
Shamir's trick with 8 points tested OK
Mar 2, 2023
f874ae8
Adding external js test module
Mar 6, 2023
523f257
precomputation of table with sage script
Mar 7, 2023
3ee7af7
precomputations using sstore2
Mar 8, 2023
13f76dd
add use of extcodecopy instead of sstore2
Mar 8, 2023
87ba943
optimizing register for gas cost
Mar 8, 2023
49a23f7
Optimizing with assembly
Mar 8, 2023
7a4a6b7
more assembly
Mar 8, 2023
c031999
Inlining assembly in main ec_mulmuladd loop
Mar 9, 2023
776c9da
Full ASM inlining of main loop
Mar 10, 2023
83855d2
asm ordering
Mar 10, 2023
27e3fbd
remove console log
Mar 10, 2023
3a0a39b
modular inversion using modexp precompiles
Mar 13, 2023
22713f6
Inline assembly for the non precomputed validate
Mar 14, 2023
990b992
Separating FCL functions from Drerup library
Mar 14, 2023
ce2faf1
Adding FCL elliptic Sutherland XYZZ representation in assembly
Mar 14, 2023
b94782a
Removing unused debug dependencies
Mar 15, 2023
01c9018
one register spared
Mar 16, 2023
fccce0f
inverting y trick
Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
420 changes: 0 additions & 420 deletions contracts/EllipticCurve.sol
View file
Open in desktop

This file was deleted.

1,617 changes: 1,617 additions & 0 deletions contracts/Elliptic_ZZ.sol
View file
Open in desktop

Large diffs are not rendered by default.

558 changes: 558 additions & 0 deletions contracts/FCL_elliptic.sol
View file
Open in desktop

Large diffs are not rendered by default.

35 changes: 29 additions & 6 deletions contracts/Webauthn.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,31 @@
pragma solidity ^0.8.0;

import {Base64URL} from "./Base64URL.sol";
import {EllipticCurve} from "./EllipticCurve.sol";
import {FCL_Elliptic_ZZ} from "./FCL_elliptic.sol";
import "hardhat/console.sol";



error InvalidAuthenticatorData();
error InvalidClientData();
error InvalidSignature();

contract Webauthn {
uint256 public counter;


function ecdsa_verif( bytes32 hash, uint[2] memory rs,
uint[2] memory Q) public returns (bool)
{
// bytes32 message = sha256(verifyData);
console.log("hash=", uint(hash));
console.log("rs0=", rs[0]);

bool result=FCL_Elliptic_ZZ.ecdsa_verify(bytes32(hash), rs, Q);
console.log("result= %s", result);

}

function checkSignature(
bytes memory authenticatorData,
bytes1 authenticatorDataFlagMask,
Expand All @@ -20,7 +35,7 @@ contract Webauthn {
uint clientChallengeDataOffset,
uint[2] memory rs,
uint[2] memory Q
) public view returns (bool) {
) public returns (bool) {
// Let the caller check if User Presence (0x01) or User Verification (0x04) are set
if (
(authenticatorData[32] & authenticatorDataFlagMask) !=
Expand Down Expand Up @@ -64,10 +79,21 @@ contract Webauthn {
verifyData,
authenticatorData.length
);

/*
uint8 tmp=verifyData[0];
console.log("verifyData:", tmp);
*/
bytes32 message = sha256(verifyData);
return EllipticCurve.validateSignature(message, rs, Q);
//bool result=Ec_ZZ.validateSignature(message, rs, Q);
bool result=FCL_Elliptic_ZZ.ecdsa_verify(message, rs, Q);
console.log("result= %s", result);

return result;
}



function validate(
bytes memory authenticatorData,
bytes1 authenticatorDataFlagMask,
Expand All @@ -93,9 +119,6 @@ contract Webauthn {
counter++;
}

/*
The following function has been written by Alex Beregszaszi (@axic), use it under the terms of the MIT license
*/
function copyBytes(
bytes memory _from,
uint _fromOffset,
Expand Down
Loading