Skip to content

feat: add rtl field to manifest entries - #87

Merged
Abhijay007 merged 2 commits into
btcpayserver:mainfrom
teamssUTXO:main
Jul 3, 2026
Merged

Abhijay007 merged 2 commits into
btcpayserver:mainfrom
teamssUTXO:main

Conversation

@teamssUTXO

Copy link
Copy Markdown
Collaborator

Related to btcpayserver/btcpayserver#7408

Will improve RTL support in the BTCPay Server .

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: adb47a66-b087-4020-b491-40c99e00359b

📥 Commits

Reviewing files that changed from the base of the PR and between cbf9200 and 9022387.

📒 Files selected for processing (3)
  • Translator.Tests/Services/ManifestGeneratorTests.cs
  • Translator/Models/ManifestEntry.cs
  • Translator/Services/ManifestGenerator.cs

📝 Walkthrough

Walkthrough

ManifestEntry adds a bool Rtl field. ManifestGenerator.BuildEntry populates it from langInfo.IsRightToLeft. Tests add an RTL assertion for Arabic and update existing fixture objects to include Rtl: false.

Changes

RTL flag in manifest

Layer / File(s) Summary
ManifestEntry model and generator wiring
Translator/Models/ManifestEntry.cs, Translator/Services/ManifestGenerator.cs
ManifestEntry record gains bool Rtl parameter; ManifestGenerator.BuildEntry passes Rtl: langInfo.IsRightToLeft when constructing entries.
Tests
Translator.Tests/Services/ManifestGeneratorTests.cs
Adds Assert.False(entry.Rtl) to the existing valid-file test, introduces a new Arabic-language test asserting Rtl == true, and updates seeded ManifestEntry objects in SHA-retention tests with Rtl: false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐇 A flag for the right, a flag for the left,
No manifest entry shall ever feel bereft.
Arabic scripts now proudly say "true,"
While English stays false as the morning dew.
Hop hop hooray, the RTL is through! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding an RTL field to manifest entries.
Description check ✅ Passed The description is directly related to the change and mentions improving RTL support, matching the updated manifest behavior.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamssUTXO
teamssUTXO requested a review from Abhijay007 June 30, 2026 19:09
@teamssUTXO

teamssUTXO commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Hi abhijay, I just wanna add you as reviewer to be aware of this change, and let you check if I haven't forgotten anything that needs changing

@Abhijay007 Abhijay007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abhijay007
Abhijay007 merged commit 3cfd27b into btcpayserver:main Jul 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants