Add cmake support to protocolbuffers/cpp plugins to v25 #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkwarren I know I'm missing something with squashing layers. Lmk what I should update. |
pkwarren
reviewed
Nov 13, 2024
| @@ -18,7 +18,10 @@ RUN bazel build '//:protoc_lib' | |||
| COPY --link BUILD cpp.cc plugins/ | |||
| RUN bazel build '//plugins:protoc-gen-cpp.stripped' | |||
|
|
|||
| FROM gcr.io/distroless/cc-debian12:latest@sha256:e6ae66a5a343d7112167f9117c4e630cfffcd80db44e44302759ec13ddd2d22b | |||
| COPY --from=build --link --chmod=0755 /build/bazel-bin/plugins/protoc-gen-cpp . | |||
| FROM gcr.io/distroless/cc-debian12:latest@sha256:e6ae66a5a343d7112167f9117c4e630cfffcd80db44e44302759ec13ddd2d22b AS base | |||
There was a problem hiding this comment.
Let's bump to the latest version from .github/docker/Dockerfile.distroless-cc-debian here (this is what our plugin fetcher uses to keep base images updated).
| RUN bazel build '//plugins:protoc-gen-cpp.stripped' | ||
| COPY --link disable_cpp_editions.patch . | ||
| RUN git apply < disable_cpp_editions.patch \ | ||
| && bazel build '//plugins:protoc-gen-cpp.stripped' |
There was a problem hiding this comment.
If we're updating this plugin lets merge the latest changes from 25.3 or 28.3 into here (including changing base images to bookworm/debian12, updating base images to latest, and reducing image layers).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also squash layers