Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make lint in CI instead of golangci-lint action #70

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Use make lint in CI instead of golangci-lint action #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4b7be1
Pin CI version to the same version as what's run in make lint
oliversun9 Oct 26, 2023
2b8920f
add comment
oliversun9 Oct 26, 2023
11da4f3
remove apostrophe
oliversun9 Oct 26, 2023
2645455
use make lint
oliversun9 Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,4 @@ jobs:
# Often, lint guidelines depend on the Go version. To prevent
# conflicting guidance, run only on the most recent supported version.
if: matrix.go-version == 'stable'
uses: golangci/golangci-lint-action@v3
with:
skip-pkg-cache: true
only-new-issues: true
args: >
--modules-download-mode=readonly
--timeout=3m0s
./...
run: make lint
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ lint: lint-proto lint-go ## Lint code and protos

.PHONY: lint-go
lint-go: $(BIN)/golangci-lint
$(BIN)/golangci-lint run ./...
$(BIN)/golangci-lint run --modules-download-mode=readonly --timeout=3m0s ./...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this is interesting! @oliversun9 can you also update connectrpc/connect-go and bufbuild/skeleton-oss-go to use this flag? I think those are the repositories we usually use as templates, so if we update them the change will eventually spread to the other repos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! They are here: connectrpc/connect-go#617 and https://github.com/bufbuild/skeleton-oss-go/pull/8


.PHONY: lint-proto
lint-proto: $(BIN)/buf
Expand Down