Check whether scalar fields are empty in (buf.validate.oneof).required #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversun9
commented
Nov 1, 2023
| return validationErr | ||
| } | ||
| if presentFieldDescriptor.Kind() == protoreflect.GroupKind || presentFieldDescriptor.Kind() == protoreflect.MessageKind { | ||
| if !msg.Get(presentFieldDescriptor).Message().IsValid() { |
There was a problem hiding this comment.
IsValid checks this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to check whether a scalar field is present when enforcing
(buf.validate.oneof).required,while checking whether a scalar field is not empty when enforcing
(buf.validate.field).required.This PR updates
(buf.validate.oneof).required's semantics to check a scalar field is not empty (as opposed to present) in(buf.validate.oneof).required.Conformance tests are updated in bufbuild/protovalidate#123