Support string.host_and_port standard constraint #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
approved these changes
Feb 12, 2024
| func (l lib) isHostAndPort(val string, portRequired bool) bool { | ||
| splitIdx := strings.LastIndexByte(val, ':') | ||
|
|
||
| if val[0] == '[' { // ipv6 |
There was a problem hiding this comment.
Should this verify the string isn't empty first?
pkwarren
approved these changes
Feb 12, 2024
charithe
referenced
this pull request
in cerbos/cerbos-sdk-go
Feb 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/bufbuild/protovalidate-go](https://togithub.com/bufbuild/protovalidate-go) | `v0.5.1` -> `v0.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/golangci/golangci-lint](https://togithub.com/golangci/golangci-lint) | `v1.56.1` -> `v1.56.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | `v1.61.0` -> `v1.61.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bufbuild/protovalidate-go (github.com/bufbuild/protovalidate-go)</summary> ### [`v0.5.2`](https://togithub.com/bufbuild/protovalidate-go/releases/tag/v0.5.2) [Compare Source](https://togithub.com/bufbuild/protovalidate-go/compare/v0.5.1...v0.5.2) #### What's Changed - Support string.host_and_port standard constraint by [@​rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protovalidate-go/pull/95](https://togithub.com/bufbuild/protovalidate-go/pull/95) **Full Changelog**: bufbuild/protovalidate-go@v0.5.1...v0.5.2 </details> <details> <summary>golangci/golangci-lint (github.com/golangci/golangci-lint)</summary> ### [`v1.56.2`](https://togithub.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1562) [Compare Source](https://togithub.com/golangci/golangci-lint/compare/v1.56.1...v1.56.2) 1. updated linters - `go-critic`: from 0.11.0 to 0.11.1 - `gosec`: from 2.18.2 to 2.19.0 - `testifylint`: from 1.1.1 to 1.1.2 - `usestdlibvars`: from 1.24.0 to 1.25.0 - `wsl`: from 4.2.0 to 4.2.1 2. misc. - Fix missing version in Docker image 3. Documentation - Explain the limitation of new-from-rev and new-from-patch </details> <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.61.1`](https://togithub.com/grpc/grpc-go/releases/tag/v1.61.1): Release 1.61.1 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.61.0...v1.61.1) ### Bug Fixes - server: wait to close connection until incoming socket is drained (with timeout) to prevent data loss on client-side ([#​6977](https://togithub.com/grpc/grpc-go/issues/6977)) - Special Thanks: [@​s-matyukevich](https://togithub.com/s-matyukevich) for discovering the root cause </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE5MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
charithe
referenced
this pull request
in cerbos/cerbos
Feb 19, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go | `v1.32.0-20231115204500-e097f827e652.1` -> `v1.32.0-20240212200630-3014d81c3a48.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) | `v1.50.15` -> `v1.50.20` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/bufbuild/protovalidate-go](https://togithub.com/bufbuild/protovalidate-go) | `v0.5.1` -> `v0.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/cerbos/cloud-api](https://togithub.com/cerbos/cloud-api) | `v0.1.16` -> `v0.1.17` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/gdamore/tcell/v2](https://togithub.com/gdamore/tcell) | `v2.7.0` -> `v2.7.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/google/cel-go](https://togithub.com/google/cel-go) | `v0.19.0` -> `v0.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/tidwall/gjson](https://togithub.com/tidwall/gjson) | `v1.17.0` -> `v1.17.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/vektra/mockery/v2](https://togithub.com/vektra/mockery) | `v2.40.3` -> `v2.42.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | golang.org/x/exp | `2c58cdc` -> `ec58324` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | golang.org/x/tools | `v0.17.0` -> `v0.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [google.golang.org/genproto/googleapis/api](https://togithub.com/googleapis/go-genproto) | `31a09d3` -> `012b6fc` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | `v1.61.0` -> `v1.61.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [modernc.org/sqlite](https://gitlab.com/cznic/sqlite) | `v1.28.0` -> `v1.29.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | --- ### Release Notes <details> <summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary> ### [`v1.50.20`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15020-2024-02-16) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.19...v1.50.20) \=== ##### Service Client Updates - `service/connectparticipant`: Updates service documentation - `service/elasticmapreduce`: Updates service API and documentation - adds fine grained control over Unhealthy Node Replacement to Amazon ElasticMapReduce - `service/firehose`: Updates service API and documentation - This release adds support for Data Message Extraction for decompressed CloudWatch logs, and to use a custom file extension or time zone for S3 destinations. - `service/lambda`: Updates service documentation - Documentation-only updates for Lambda to clarify a number of existing actions and properties. - `service/rds`: Updates service API, documentation, waiters, paginators, and examples - Doc only update for a valid option in DB parameter group - `service/sns`: Updates service API and documentation - This release marks phone numbers as sensitive inputs. ### [`v1.50.19`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15019-2024-02-15) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.18...v1.50.19) \=== ##### Service Client Updates - `service/artifact`: Updates service API, documentation, paginators, and examples - `service/codepipeline`: Updates service API and documentation - Add ability to override timeout on action level. - `service/detective`: Updates service documentation - `service/guardduty`: Updates service API and documentation - Marked fields IpAddressV4, PrivateIpAddress, Email as Sensitive. - `service/healthlake`: Updates service API and documentation - `service/opensearch`: Updates service API and documentation - `service/polly`: Updates service API - Amazon Polly adds 1 new voice - Burcu (tr-TR) - `service/sagemaker`: Updates service API and documentation - This release adds a new API UpdateClusterSoftware for SageMaker HyperPod. This API allows users to patch HyperPod clusters with latest platform softwares. - `service/secretsmanager`: Updates service documentation - Doc only update for Secrets Manager ### [`v1.50.18`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15018-2024-02-14) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.17...v1.50.18) \=== ##### Service Client Updates - `service/controltower`: Updates service API, documentation, and paginators - `service/lookoutequipment`: Updates service API and documentation - `service/qbusiness`: Updates service API and documentation ### [`v1.50.17`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15017-2024-02-13) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.16...v1.50.17) \=== ##### Service Client Updates - `service/lightsail`: Updates service API and documentation - This release adds support to upgrade the major version of a database. - `service/marketplace-catalog`: Updates service API and documentation - `service/resource-explorer-2`: Adds new service - `service/securitylake`: Updates service documentation ### [`v1.50.16`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15016-2024-02-12) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.15...v1.50.16) \=== ##### Service Client Updates - `service/appsync`: Updates service API and documentation - `service/monitoring`: Updates service API - This release enables PutMetricData API request payload compression by default. - `service/route53domains`: Updates service API and documentation - This release adds bill contact support for RegisterDomain, TransferDomain, UpdateDomainContact and GetDomainDetail API. </details> <details> <summary>bufbuild/protovalidate-go (github.com/bufbuild/protovalidate-go)</summary> ### [`v0.5.2`](https://togithub.com/bufbuild/protovalidate-go/releases/tag/v0.5.2) [Compare Source](https://togithub.com/bufbuild/protovalidate-go/compare/v0.5.1...v0.5.2) #### What's Changed - Support string.host_and_port standard constraint by [@​rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protovalidate-go/pull/95](https://togithub.com/bufbuild/protovalidate-go/pull/95) **Full Changelog**: bufbuild/protovalidate-go@v0.5.1...v0.5.2 </details> <details> <summary>cerbos/cloud-api (github.com/cerbos/cloud-api)</summary> ### [`v0.1.17`](https://togithub.com/cerbos/cloud-api/compare/v0.1.16...v0.1.17) [Compare Source](https://togithub.com/cerbos/cloud-api/compare/v0.1.16...v0.1.17) </details> <details> <summary>gdamore/tcell (github.com/gdamore/tcell/v2)</summary> ### [`v2.7.1`](https://togithub.com/gdamore/tcell/releases/tag/v2.7.1): Version 2.7.1 Bug Fix Release [Compare Source](https://togithub.com/gdamore/tcell/compare/v2.7.0...v2.7.1) This release fixes a few problems, and also adds a feature that was missing on Windows. - Fix for disappearing wide (including emoji) characters on Windows ([#​621](https://togithub.com/gdamore/tcell/issues/621)) - Fix for wide characters causing scrolling when on bottom line on UNIX/Linux ([#​679](https://togithub.com/gdamore/tcell/issues/679)) - Fix for PollEvent returning nil on screen Suspend (regression) ([#​687](https://togithub.com/gdamore/tcell/issues/687)) - Fix for AltGr modifiers on Windows, contributed by stk <[email protected]> Additionally: - Support for the termite (defunct) was removed from the built-in terminals. The fallback support by parsing terminfo still works. The termite project is now abandoned and the project advises users to use Alacritty (which is natively supported in tcell.) - Support for focus event reporting was added for Windows - The Views API no longer uses deprecated tcell functions internally ([#​682](https://togithub.com/gdamore/tcell/issues/682)) </details> <details> <summary>google/cel-go (github.com/google/cel-go)</summary> ### [`v0.20.0`](https://togithub.com/google/cel-go/releases/tag/v0.20.0) [Compare Source](https://togithub.com/google/cel-go/compare/v0.19.0...v0.20.0) #### What's Changed - Minor adjustment to inlining to fix a bad bind \[[#​888](https://togithub.com/google/cel-go/issues/888)] - Ensure error typed variables are returned as errors from Resolve b \[[#​889](https://togithub.com/google/cel-go/issues/889)] - ext.NativeTypes: Recursively add sub-types \[[#​892](https://togithub.com/google/cel-go/issues/892)] - DefaultTypeAdapter: Add support for missing custom scalars \[[#​893](https://togithub.com/google/cel-go/issues/893)] - Lists: Fix handling of go arrays \[[#​894](https://togithub.com/google/cel-go/issues/894)] #### New Contributors - [@​alvaroaleman](https://togithub.com/alvaroaleman) made their first contribution in [https://github.com/google/cel-go/pull/892](https://togithub.com/google/cel-go/pull/892) **Full Changelog**: google/cel-go@v0.19.0...v0.20.0 </details> <details> <summary>tidwall/gjson (github.com/tidwall/gjson)</summary> ### [`v1.17.1`](https://togithub.com/tidwall/gjson/compare/v1.17.0...v1.17.1) [Compare Source](https://togithub.com/tidwall/gjson/compare/v1.17.0...v1.17.1) </details> <details> <summary>vektra/mockery (github.com/vektra/mockery/v2)</summary> ### [`v2.42.0`](https://togithub.com/vektra/mockery/releases/tag/v2.42.0) [Compare Source](https://togithub.com/vektra/mockery/compare/v2.41.0...v2.42.0) #### Changelog - [`29471fe`](https://togithub.com/vektra/mockery/commit/29471fe) Add more users of mockery to docs - [`e420a13`](https://togithub.com/vektra/mockery/commit/e420a13) Add typeset plugin for docs - [`8d53849`](https://togithub.com/vektra/mockery/commit/8d53849) Factor out logic to exclude sub-modules - [`b915439`](https://togithub.com/vektra/mockery/commit/b915439) Fix issue with file ordering - [`601d297`](https://togithub.com/vektra/mockery/commit/601d297) Merge branch 'master' into replace-generic - [`528d354`](https://togithub.com/vektra/mockery/commit/528d354) Merge branch 'master' into users - [`8b86cf2`](https://togithub.com/vektra/mockery/commit/8b86cf2) Merge pull request [#​750](https://togithub.com/vektra/mockery/issues/750) from DustinJSilk/replace-generic - [`92afb14`](https://togithub.com/vektra/mockery/commit/92afb14) Merge pull request [#​759](https://togithub.com/vektra/mockery/issues/759) from LandonTClipp/users - [`3b25f39`](https://togithub.com/vektra/mockery/commit/3b25f39) Merge pull request [#​760](https://togithub.com/vektra/mockery/issues/760) from LandonTClipp/fix_ordering - [`f0789fb`](https://togithub.com/vektra/mockery/commit/f0789fb) Merge pull request [#​761](https://togithub.com/vektra/mockery/issues/761) from LandonTClipp/file_ordering_gomod - [`e724b8a`](https://togithub.com/vektra/mockery/commit/e724b8a) Show support for pointer type replacements - [`78755a1`](https://togithub.com/vektra/mockery/commit/78755a1) fixes - [`d39a2a2`](https://togithub.com/vektra/mockery/commit/d39a2a2) make codecov more permissive - [`4b08243`](https://togithub.com/vektra/mockery/commit/4b08243) use replace-type config ### [`v2.41.0`](https://togithub.com/vektra/mockery/releases/tag/v2.41.0) [Compare Source](https://togithub.com/vektra/mockery/compare/v2.40.3...v2.41.0) #### Changelog - [`d4e7f57`](https://togithub.com/vektra/mockery/commit/d4e7f57) Merge pull request [#​757](https://togithub.com/vektra/mockery/issues/757) from LandonTClipp/go_mod_version - [`2c2727b`](https://togithub.com/vektra/mockery/commit/2c2727b) Set go.mod to go 1.22 </details> <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.61.1`](https://togithub.com/grpc/grpc-go/releases/tag/v1.61.1): Release 1.61.1 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.61.0...v1.61.1) ### Bug Fixes - server: wait to close connection until incoming socket is drained (with timeout) to prevent data loss on client-side ([#​6977](https://togithub.com/grpc/grpc-go/issues/6977)) - Special Thanks: [@​s-matyukevich](https://togithub.com/s-matyukevich) for discovering the root cause </details> <details> <summary>cznic/sqlite (modernc.org/sqlite)</summary> ### [`v1.29.1`](https://gitlab.com/cznic/sqlite/compare/v1.29.0...v1.29.1) [Compare Source](https://gitlab.com/cznic/sqlite/compare/v1.29.0...v1.29.1) ### [`v1.29.0`](https://gitlab.com/cznic/sqlite/compare/v1.28.0...v1.29.0) [Compare Source](https://gitlab.com/cznic/sqlite/compare/v1.28.0...v1.29.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE5MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Charith Ellawala <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Charith Ellawala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.