docs(input): document custom-keymap workaround for unreachable Alt-s on macOS Terminal.app - #390
Merged
Merged
Conversation
…on macOS Terminal.app PR #387 correctly removed the composed-char rewrite for ç/ß in map_macos_composed_char, but that left Alt-s (split_selection_on_newline) physically unreachable via Option+s on macOS terminals without kitty keyboard protocol support (e.g. Terminal.app), breaking the advanced-selection scenario for those users. Rather than reintroduce the layout collision, this documents the existing custom Helix keymap overlay (#350) as a working, zero-regression-risk path: remapping a plain, unambiguous key to split_selection_on_newline resolves to the same canonical Alt-s a real keystroke would produce. Alt-c has the same theoretical reachability gap but currently has no executable command behind it in the trainer at all, so there is nothing to document a workaround for; that gap is tracked separately in #389. Fixes #386
bug-ops
enabled auto-merge (squash)
August 9, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ç/ßcomposed-char rewrite frommap_macos_composed_charto fix a layout collision (map_macos_composed_char rewrites plain ç/ß to Alt-c/Alt-s on non-US keyboard layouts #381/Two map_macos_composed_char entries may be mismapped against the real macOS US Option+Shift layout (˝→Alt-J, ¯→Alt-_) #382), but that leftAlt-s(split_selection_on_newline) unreachable via Option+s on macOS terminals without kitty keyboard protocol support (e.g. Terminal.app), breakingadvanced-selection.toml'ssplit_selection_newlines_001step.key_mapping.rs/behavior change is made here — the custom Helix keymap overlay (feat(input): support custom Helix keymap remapping #350) already provides a working, zero-regression-risk path (remapping a plain key tosplit_selection_on_newlineresolves to the same canonicalAlt-s). This PR documents it: a new README subsection, a CHANGELOG entry, a scenario hint, and one regression test confirming the remap-to-canonical-Alt-chord resolution.Alt-chas the same theoretical reachability gap but has no executable command behind it in the trainer at all, so no workaround is documented for it; that gap is filed separately as Alt-c (CMD_CHANGE_SELECTION_NOYANK) has no executable command behind it #389.Test plan
cargo nextest run --workspace --all-features --lib --bins(2215 passed)cargo nextest run scenario(277 passed)cargo +nightly fmt --checkcargo clippy --all-targets --all-features --workspace -- -D warningsRUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspaceFixes #386