test(mcp-skill): pin declared-field alias-bomb retype vector - #361
Merged
Conversation
…rontmatter Add regression coverage for the second alias-bomb resistance vector: retyping an already-declared field (e.g. description) to a buffering type, distinct from the flatten/unknown-key vector covered previously. Adds two canary tests pinning serde_norway's own buffering behavior (Value-typed retype, which is compile-blocked in production, and a deserialize_with retype, which is not) plus a production-coupled test confirming RawFrontmatter does not hit this path today. Corrects ADR-341 with an addendum recording the vector and its timing figures' original source. Closes #359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RawFrontmatter: retyping an already-declared field (e.g.description) fromOption<String>to a buffering type, distinct from the flatten/unknown-key vector covered by the prior regression test.serde_norway's own buffering behavior directly: aValue-typed retype (compile-blocked in production today, kept as a mechanism baseline) and adeserialize_withretype (not compile-blocked — the realistic silent-regression case).extract_skill_metadata+RawFrontmatterdoes not hit the repetition-limit path, and will fail loudly ifRawFrontmatteris ever retyped to a buffering shape.[Unreleased] > Testing.Went through two rounds of adversarial critique (first verdict: significant — no coupling to production code, covered the compile-blocked variant instead of the silent one, an overly loose
is_err()assertion; second verdict: minor — wording/doc-order nits plus adopting the production-coupled 4th test). All findings addressed and re-verified.Closes #359
Test plan
cargo nextest run -p mcp-execution-skill -E 'test(alias_bomb)'— 4/4 passcargo nextest run --workspace --all-features --lib --bins— 987/987 passcargo test --doc --all-features --workspace— 40/40 passcargo +nightly fmt --check— cleancargo clippy --all-targets --all-features --workspace -- -D warnings— clean