refactor(acp): migrate to agent-client-protocol 2.0.0 - #6658
Merged
Conversation
Bump agent-client-protocol 1.2.0 -> 2.0.0 (schema =1.4.0 -> =1.5.0) in crates/zeph-acp, per the migration plan in specs/013-acp/spec.md. Mechanical crate-major bump: the wire protocol stays at V1, no handler/transport/ builder-chain logic changed. Adds a compile-time regression guard plus a runtime test that hardcode the wire version so a future schema-pin bump can't silently redefine it, and a new integration test covering the SDK's newly-accepted JSON-RPC batch requests end to end through the dispatch loop. Also fixes specs/013-acp/spec.md sections that still asserted a stale pre-1.2.0 protocol version as current state, and corrects several inaccuracies uncovered during review (handler/route table for protocol_version exposure, cargo-deny evidence, Gap Tracker references). Closes #6655 Closes #6633
bug-ops
force-pushed
the
feat/6655-migrate-acp-2-0-0
branch
from
July 27, 2026 19:49
a37c19b to
5b1dfb2
Compare
bug-ops
enabled auto-merge (squash)
July 27, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-client-protocol1.2.0->2.0.0(schema=1.4.0->=1.5.0) incrates/zeph-acp, per the migration plan inspecs/013-acp/spec.md. Mechanical crate-major bump: the wire protocol Zeph speaks stays atV1; zero handler/transport/builder-chain source changes were needed (the three named compiler-verify points from the spec all compiled clean).crates/zeph-acp/src/lib.rs) plus an independent runtime test that both hardcode the wire version, so a future schema-pin bump can't silently redefineProtocolVersion::LATESTaway from1without failing the build/tests.specs/013-acp/spec.mdsections that still asserted a stale pre-1.2.0 protocol version as current state, plus several other inaccuracies uncovered during review (the/agent.jsonvs/.well-known/acp.jsonhandler/route table,cargo-denyevidence, Implementation Gap Tracker cross-references).Process notes
This went through the full
refactoringchain (developer -> parallel tester/security/impl-critic -> code review), with one consolidated fix round after the critic'ssignificantverdict (3 blocking gaps: stale README version, unverified fork/providers test-coverage claims, untested batch-dispatch path) and the tester/security findings from the same pass. The reviewer found and fixed two more issues live with the developer during final review (a stale/agent.jsonexample in the spec, and a wrongcargo-denyinvocation/evidence). Security's audit found zero new vulnerabilities from this bump; it separately surfaced a pre-existing (not introduced by this PR) HIGH-severity permission-gate deadlock, filed as #6656.Closes #6655
Closes #6633
Test plan
cargo +nightly fmt --checkcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warningscargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins(15073 tests, all passing)cargo nextest run -p zeph-acpwith the full unstable-feature set (222 tests, incl. 2 new regression tests)RUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace ...)cargo test --doc --workspace ...cargo deny --config .github/deny.toml check(zero new advisories from the bump; same 3 pre-existing accepted advisories)gitleaks protect --staged --no-banner --redactinitialize->session/new->session/promptagainst a real local Ollama model, plusfork/resume/session/delete/logout/set_config_option/set_mode/block_taskexercised by thezeph-acpintegration suite under 2.0.0;/agent.jsonand/.well-known/acp.jsonfield exposure verified against the actual handler code (only the latter carriesprotocol_version, confirmed against the upstream ACP Registry RFD)