BC-27536: Relay state, and assorted other fixes #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the RelayState from the request all the way to the response (required because we're going to use relaystate to correlate saml login requests to responses in hodor) Sign saml responses to better match what production IdP instances will be doing Add `gcompat` apk package in dockerfile to fix builds when running on ARM macs (see https://stackoverflow.com/questions/70963924/unable-to-load-nokogiri-in-docker-container-on-m1-mac) Signed-off-by: Hamish Farrant <[email protected]>
mo5h
deleted the
BC-27536-pass-relay-state-through-also-sign-requests-and-fix-builds-on-arm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the RelayState from the request all the way to the response (required because we're going to use relaystate to correlate saml login requests to responses in hodor)
Sign saml responses to better match what production IdP instances will be doing
Add
gcompatapk package in dockerfile to fix builds when running on ARM macs (see https://stackoverflow.com/questions/70963924/unable-to-load-nokogiri-in-docker-container-on-m1-mac)