Skip to content

Fix locals not showing with mago-mi.exe on Windows. Issue #192 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix locals not showing with mago-mi.exe on Windows. Issue #192 #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2593f2
Fix locals not showing with mago-mi.exe on Windows. Issue #192
Siemargl Sep 16, 2020
cd429d7
Upgrade depencies to latest DCD & DlangUI
Siemargl Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions dub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@
"stringImportPaths": ["views"],

"dependencies": {
"dlangui": "==0.9.182",
"dsymbol": "~>0.4.8",
"dcd": "~>0.9.13"
"dlangui": "==0.9.186",
"dcd": "~>0.13.1"
},

"copyFiles-windows": [
Expand Down
8 changes: 8 additions & 0 deletions src/ddebug/gdb/gdbmiparser.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,14 @@ DebugThreadList parseThreadList(MIValue params) {
res.threads ~= t;
}
}
// Workaround for answer threads=[]
if (res.length == 0)
{
auto mainTh = new DebugThread();
mainTh.id = res.currentThreadId;
mainTh.name = "Single";
res.threads ~= mainTh;
}
return res;
}

Expand Down
9 changes: 4 additions & 5 deletions src/dlangide/tools/d/dcdinterface.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,9 @@ class DCDInterface : Thread {
override void performRequest() {
AutocompleteResponse response = getDoc(request, *getModuleCache(_importPaths));

result.docComments = response.docComments.dup;
foreach (ref completion; response.completions)
result.docComments ~= completion.documentation.escapeConsoleOutputString(true);

result.result = DCDResult.SUCCESS;

debug(DCD) Log.d("DCD doc comments:\n", result.docComments);
Expand Down Expand Up @@ -318,10 +320,7 @@ class DCDInterface : Thread {
result.output.length = response.completions.length;
int i=0;
foreach(s;response.completions) {
char type = 0;
if (i < response.completionKinds.length)
type = response.completionKinds[i];
result.output[i].kind = type;
result.output[i].kind = s.kind;
result.output[i].name = to!dstring(s);
i++;
}
Expand Down