Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue causing flags cleared by calling +[Bugsnag clearFeatureFlagWithName:] to appear in crash reports #1740

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

robert-smartbear
Copy link
Contributor

Goal

Due to a bug in BSGAtomicFeatureFlagStore, feature flags that are cleared by name were not removed completely and would appear in crash reports

Changeset

Fixed the implementation of BSGAtomicFeatureFlagStore.

Testing

E2E tests

…reFlagWithName:] to appear in crash reports
Copy link

Bugsnag.framework binary size increased by 400 bytes from 669,160 to 669,560

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +220  +0.1%    +220    __TEXT,__text
  +0.1%    +208  +0.1%    +208    Symbol Table
  +0.1%    +160  +0.1%    +160    String Table
  +1.1%     +32  +1.1%     +32    Binding Info
  +0.9%     +32  +0.9%     +32    __DATA,__const
  +0.2%     +32  +0.2%     +32    __TEXT,__objc_stubs
  +0.1%     +18  +0.1%     +18    __TEXT,__objc_methname
  [ = ]       0  +0.2%     +16    __DATA,__bss
  +1.1%      +8  +1.1%      +8    __DATA,__objc_classrefs
  +0.2%      +8  +0.2%      +8    __DATA,__objc_selrefs
  -0.8%     -48  -0.5%     -64    [__DATA]
  -1.4%    -270  -1.4%    -270    [__TEXT]
  [ = ]       0 -15.5%    -400    [__LINKEDIT]
  +0.1%    +400  [ = ]       0    TOTAL

Generated by 🚫 Danger

@robert-smartbear robert-smartbear merged commit 2e16dfa into next Feb 21, 2025
45 checks passed
@robert-smartbear robert-smartbear deleted the robert/plat-13735_feature_flag_clear_fix branch February 21, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants