Remove dependency on creack/goselect in favor of sys/unix
#149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
remove_goselect_dep
branch
from
3343dd3 to
768050c
Compare
|
Is anything holding this back? |
cmaglie
force-pushed
the
remove_goselect_dep
branch
from
768050c to
7a4f0a3
Compare
2 tasks
cmaglie
force-pushed
the
remove_goselect_dep
branch
from
7a4f0a3 to
ee3c924
Compare
|
@cmaglie now that goselect module is even marked as archived... would be nice to get rid of this redundant dep! |
cmaglie
force-pushed
the
remove_goselect_dep
branch
from
ee3c924 to
0c6b3f4
Compare
quite
approved these changes
May 13, 2025
|
I'm excited to see this merged! Thanks for your hard work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the functions in the old library are now available in
x/sys/unix.Also updated other dependencies for testing:*github.com/davecgh/go-spew=>v1.1.1*[edit: done in another PR]gopkg.in/yaml.v3=>v3.0.1