Skip to content

Feature RS485 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature RS485 #170

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e1a84d8
Merge of RS485
AndreRenaud Dec 8, 2023
d3432f7
Merge branch 'master' into andre-rs485
AndreRenaud May 27, 2024
bdfda6f
Remove windows call - it is no longer used in this PR
AndreRenaud May 27, 2024
9f3f1f3
Merge remote-tracking branch 'upstream/master' into andre-rs485
AndreRenaud Jul 4, 2024
5f910bc
Merge remote-tracking branch 'upstream/master' into andre-rs485
AndreRenaud Mar 19, 2025
4162208
rs485: Remove custom ioctl definition & use unix constant
AndreRenaud Mar 19, 2025
073fb25
Revert "rs485: Remove custom ioctl definition & use unix constant"
AndreRenaud Mar 19, 2025
0e1abfa
Remove unncecessary new error codes
AndreRenaud Mar 21, 2025
db82678
Merge remote-tracking branch 'upstream/master' into andre-rs485
AndreRenaud Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions serial_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
rs485RTSOnSend = 1 << 1
rs485RTSAfterSend = 1 << 2
rs485RXDuringTX = 1 << 4
rs485Tiocs = 0x542f
)

// rs485_ioctl_opts is used to configure RS485 options in the driver
Expand Down Expand Up @@ -511,5 +510,5 @@
rs485.flags |= rs485RXDuringTX
}

return unix.IoctlSetInt(port.handle, rs485Tiocs, int(uintptr(unsafe.Pointer(&rs485))))
return unix.IoctlSetInt(port.handle, unix.TIOCSRS485, int(uintptr(unsafe.Pointer(&rs485))))

Check failure on line 513 in serial_unix.go

View workflow job for this annotation

GitHub Actions / cross-os-build (freebsd amd64) 

undefined: unix.TIOCSRS485

Check failure on line 513 in serial_unix.go

View workflow job for this annotation

GitHub Actions / native-os-build (macOS-latest) 

undefined: unix.TIOCSRS485

Check failure on line 513 in serial_unix.go

View workflow job for this annotation

GitHub Actions / cross-os-build (openbsd arm) 

undefined: unix.TIOCSRS485

Check failure on line 513 in serial_unix.go

View workflow job for this annotation

GitHub Actions / cross-os-build (openbsd amd64) 

undefined: unix.TIOCSRS485

Check failure on line 513 in serial_unix.go

View workflow job for this annotation

GitHub Actions / cross-os-build (openbsd 386) 

undefined: unix.TIOCSRS485
Copy link
Contributor

@cbrake cbrake Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

Copy link
Contributor Author

@AndreRenaud AndreRenaud Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tragically not though - it causes build issues on other platforms. The constant is only defined for Linux builds. Possibly that's an argument (since we're doing a Linux ioctl here) for moving this code out of serial_unix.go and into serial_linux.go?

}
Loading