fix(rust): command subprocess read child's pipes instead of copying them #8793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbenavides
changed the title
adrianbenavides
force-pushed
the
adrian/inverse-stdout-stderr-pipes
branch
from
ee773d5 to
4acfe73
Compare
adrianbenavides
force-pushed
the
adrian/inverse-stdout-stderr-pipes
branch
from
4acfe73 to
5b2f7e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inheriting pipes in a subprocess leads to problems when the parent process exits before the subprocess does.
This PR changes that behavior so that the pipes from the child and parent processes are detached and the parent drains/consumes the child's pipes directly.