-
Notifications
You must be signed in to change notification settings - Fork 95
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change default_service_config to google.protobuf.Struct
The gRPC service config is based on a Protobuf message structure defined here: https://github.com/grpc/grpc-proto/blob/master/grpc/service_config/service_config.proto Ideally we'd just embed grpc.service_config.ServiceConfig into this message, but that's easier said than done. There is no canonical Go module containing the generated Protobuf source files. Furthermore, grpc-go ships with some copies of those, but has them placed inside internal/. This means that even if we were to generate those ourselves, we'd run into a Protobuf registration conflict at runtime. Use google.protobuf.Struct, so that we can at least embed these service configs without requiring excessive quoting. This is a continuation of #236.
- Loading branch information
1 parent
7ebb551
commit 97caba9
Showing
3 changed files
with
13 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters