sluongng/proto use codecv2 #8352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sluongng
commented
Feb 10, 2025
sluongng
commented
- vtprotocodec: user codecV2 for grpc client/server
- correct capitalization
- feat: Use CodecV2 for proto encoding/decoding
Switch to use codecV2 backed by the default buffer pool to handle all
Marshaling/Unmarshaling by grpc clients/servers. The default buffer pool
is already setup here.
```
server/util/grpc_client/grpc_client.go
254: experimental.WithBufferPool(mem.DefaultBufferPool()),
server/util/grpc_server/grpc_server.go
240: experimental.BufferPool(mem.DefaultBufferPool()),
```
This does not affect the manual Marshaling/Unmarshaling that we does via
`server/util/proto.{Marshal,Unmarshal}()`. These should still use V1 for
the time being.
Route all proto encode/decode through encoding.CodecV2, which is implemented in vtprotocodec package. This means that proto encode/decode will attempt reuse the pre-allocated mem.DefaultBuffer as much as possible. Since we are copying these directly to []byte right now, there is not much benefit to this. We should investigate using mem.Buffer instead of []byte so that we can delay the materialization of the blob as late as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.